[docs] Improve XML docs for various types - #26379
Conversation
Improve XML documentation for SCNJavaScript, SecIdentity, UINavigationController, UIPushBehavior, WebFrame, NWErrorDomain, AVCaptureFileOutput, AVUrlAssetOptions, ABAddressFormatting, BCChatButtonStyle, StartAdvertisingOptions, CVMetalTextureAttributes, CWConfiguration, EKUIBundle, NSBundle, INSetProfileInCarIntent, NWProtocolOptions, NEHotspotEapSettings, DelayedRegistrationAttribute, SKAction, UICollectionViewLayout, DCError, and AVAssetDownloadStorageManagementPolicy. Changes include: - Replace placeholder parameter descriptions with meaningful descriptions - Replace generic enum summaries with specific descriptions - Remove empty remarks elements - Fix tag ordering Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
There was a problem hiding this comment.
Pull request overview
Updates XML documentation across several Apple-framework binding types in dotnet/macios, primarily replacing placeholder docs and removing empty <remarks> blocks to improve generated API documentation/IntelliSense.
Changes:
- Replace placeholder
<param>documentation with more descriptive text for various APIs. - Improve some enum member summaries (and remove empty
<remarks>tags). - Clean up XML doc structure by removing empty remarks elements.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WebKit/WebKit.cs | Updates parameter XML docs for WebFrame.LoadHtmlString. |
| src/UIKit/UIPushBehavior.cs | Updates constructor parameter XML docs. |
| src/UIKit/UINavigationController.cs | Updates constructor parameter XML docs. |
| src/UIKit/UICollectionViewLayout.cs | Removes placeholder remarks and updates parameter docs. |
| src/SpriteKit/SKAction.cs | Updates parameter XML docs for ResizeTo. |
| src/Security/SecIdentity.cs | Removes placeholder <remarks> from type/property docs. |
| src/SceneKit/SCNJavaScript.cs | Removes placeholder <remarks> and improves parameter doc for ExportModule. |
| src/ObjCRuntime/DelayedRegistrationAttribute.cs | Removes placeholder <remarks> from attribute/type docs. |
| src/NetworkExtension/NEHotspotEapSettings.cs | Removes placeholder <remarks> from type/property docs. |
| src/Network/NWProtocolOptions.cs | Removes placeholder <remarks> from ProtocolDefinition docs. |
| src/network.cs | Improves enum member summaries for NWErrorDomain. |
| src/Intents/INSetProfileInCarIntent.cs | Improves constructor parameter XML docs. |
| src/Foundation/NSBundle.cs | Removes placeholder remarks and improves PathsForResources parameter doc. |
| src/EventKitUI/EKUIBundle.cs | Removes placeholder <remarks> from type/property docs. |
| src/devicecheck.cs | Improves some DCError enum member docs; removes placeholder remarks on DCDevice.Supported. |
| src/CoreWlan/CWConfiguration.cs | Removes placeholder <remarks> from type/property docs. |
| src/CoreVideo/CVMetalTextureAttributes.cs | Removes placeholder <remarks> from type/property docs. |
| src/CoreBluetooth/AdvertisementDataOptions.cs | Removes placeholder remarks and improves StartAdvertisingOptions(NSDictionary) parameter doc. |
| src/BusinessChat/Enums.cs | Improves enum member summaries for BCChatButtonStyle / BCParameterName. |
| src/AVFoundation/AVUrlAssetOptions.cs | Removes placeholder remarks and improves AVUrlAssetOptions(NSDictionary) parameter doc. |
| src/AVFoundation/AVCaptureFileOutput.cs | Improves parameter XML docs for StartRecordingToOutputFile. |
| src/AVFoundation/AVAssetDownloadStorageManagementPolicy.cs | Removes placeholder <remarks> from Priority property docs. |
| src/AddressBookUI/ABAddressFormatting.cs | Improves parameter XML docs for ABAddressFormatting.ToString. |
Suppressed comments (1)
src/network.cs:18
- 🤖 💡 Documentation — Use standard acronym casing (DNS/TLS) in these summaries so they read well in generated docs and IntelliSense.
/// <summary>Indicates dns.</summary>
[Field ("kNWErrorDomainDNS")]
Dns = 2,
/// <summary>Indicates tls.</summary>
[Field ("kNWErrorDomainTLS")]
Tls = 3,
Replace generic parameter and summary descriptions with more specific, meaningful documentation that provides value in IntelliSense tooltips. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #b057ca3] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 43 tests failed, 160 tests passed. Failures❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (macOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)19 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)19 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ msbuild tests1 tests failed, 1 tests passed.Failed tests
Html Report (VSDrops) Download ❌ windows tests1 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Improve XML documentation for 23 types across multiple frameworks.
Types documented:
SCNJavaScript, SecIdentity, UINavigationController, UIPushBehavior, WebFrame, NWErrorDomain, AVCaptureFileOutput, AVUrlAssetOptions, ABAddressFormatting, BCChatButtonStyle, StartAdvertisingOptions, CVMetalTextureAttributes, CWConfiguration, EKUIBundle, NSBundle, INSetProfileInCarIntent, NWProtocolOptions, NEHotspotEapSettings, DelayedRegistrationAttribute, SKAction, UICollectionViewLayout, DCError, AVAssetDownloadStorageManagementPolicy
Changes:
🤖 Pull request created by Copilot