Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Text;
using BenchmarkDotNet.Attributes;
using MicroBenchmarks;

Expand All @@ -10,8 +11,10 @@ namespace System.IO.Tests
[BenchmarkCategory(Categories.Libraries)]
public class BinaryWriterExtendedTests
{
private string _input;
private char[] _inputAsChars;
private string _asciiInput;
private char[] _asciiInputAsChars;
private string _nonAsciiInput;
private char[] _nonAsciiInputAsChars;
private BinaryWriter _bw;

[Params(32, 8_000, 2_000_000)]
Expand All @@ -22,22 +25,95 @@ public void Setup()
{
_bw = new BinaryWriter(new NullWriteStream());

_input = new string('x', StringLengthInChars);
_inputAsChars = _input.ToCharArray();
_asciiInput = new string('x', StringLengthInChars);
_asciiInputAsChars = _asciiInput.ToCharArray();
// '\u00E0' (à) encodes to 2 bytes in UTF-8, exercising multi-byte encoding paths
_nonAsciiInput = new string('\u00E0', StringLengthInChars);
Comment thread
jeffhandley marked this conversation as resolved.
_nonAsciiInputAsChars = _nonAsciiInput.ToCharArray();
}

[Benchmark]
[MemoryRandomization]
public void WriteAsciiCharArray()
{
_bw.Write(_inputAsChars);
_bw.Write(_asciiInputAsChars);
}

[Benchmark]
[MemoryRandomization]
public void WriteAsciiString()
{
_bw.Write(_input);
_bw.Write(_asciiInput);
}

[Benchmark]
[MemoryRandomization]
public void WriteNonAsciiCharArray()
{
_bw.Write(_nonAsciiInputAsChars);
}

[Benchmark]
[MemoryRandomization]
public void WriteNonAsciiString()
{
_bw.Write(_nonAsciiInput);
}
}

/// <summary>
/// Benchmarks for BinaryWriter using a non-UTF-8 encoding (Encoding.Unicode).
/// </summary>
Comment thread
jeffhandley marked this conversation as resolved.
[BenchmarkCategory(Categories.Libraries)]
public class BinaryWriterUnicodeEncodingTests
{
private string _asciiInput;
private char[] _asciiInputAsChars;
private string _nonAsciiInput;
private char[] _nonAsciiInputAsChars;
private BinaryWriter _bw;

[Params(32, 8_000, 2_000_000)]
public int StringLengthInChars;

[GlobalSetup]
public void Setup()
{
_bw = new BinaryWriter(new NullWriteStream(), Encoding.Unicode);

_asciiInput = new string('x', StringLengthInChars);
_asciiInputAsChars = _asciiInput.ToCharArray();
// Use a representative non-ASCII BMP character ('\u00E0', à).
_nonAsciiInput = new string('\u00E0', StringLengthInChars);
Comment thread
jeffhandley marked this conversation as resolved.
_nonAsciiInputAsChars = _nonAsciiInput.ToCharArray();
}

[Benchmark]
[MemoryRandomization]
public void WriteAsciiCharArray()
{
_bw.Write(_asciiInputAsChars);
}

[Benchmark]
[MemoryRandomization]
public void WriteAsciiString()
{
_bw.Write(_asciiInput);
}

[Benchmark]
[MemoryRandomization]
public void WriteNonAsciiCharArray()
{
_bw.Write(_nonAsciiInputAsChars);
}

[Benchmark]
[MemoryRandomization]
public void WriteNonAsciiString()
{
_bw.Write(_nonAsciiInput);
}
}
}
30 changes: 30 additions & 0 deletions src/benchmarks/micro/libraries/System.IO/BinaryWriterTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Text;
using BenchmarkDotNet.Attributes;
using MicroBenchmarks;

Expand Down Expand Up @@ -78,4 +79,33 @@ public void WriteDouble()
_bw.Write((double)Math.PI);
}
}

/// <summary>
/// Benchmarks for BinaryWriter using a non-UTF-8 encoding (Encoding.Unicode),
/// exercising the non-UTF-8 path used by Write(char).
/// </summary>
Comment thread
jeffhandley marked this conversation as resolved.
Comment on lines +83 to +86
[BenchmarkCategory(Categories.Libraries)]
public class BinaryWriterUnicodeEncodingCharTests
{
private BinaryWriter _bw;

[GlobalSetup]
public void Setup()
{
_bw = new BinaryWriter(new NullWriteStream(), Encoding.Unicode);
}

[Benchmark]
public void WriteAsciiChar()
{
_bw.Write('a');
}

[Benchmark]
public void WriteNonAsciiChar()
{
// Use a representative non-ASCII BMP character ('\u00E0', à).
_bw.Write('\u00E0');
Comment thread
jeffhandley marked this conversation as resolved.
}
}
}
Loading