Skip to content

Fix Linux prerequisite typo spellings in pre-commands - #5268

Draft
DrewScoggins with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-review-comment-3677953411
Draft

Fix Linux prerequisite typo spellings in pre-commands#5268
DrewScoggins with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-review-comment-3677953411

Conversation

Copilot AI commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

This updates the Linux prerequisite-install pre-command block to match the reviewer’s requested spelling fixes. The change is limited to the local variable name and the emitted log/error strings.

  • Scope

    • Touches only scripts/run_performance_job.py
    • No behavior change; log text and local naming only
  • Changes

    • Rename combined_prequisites to combined_prerequisites
    • Correct prerequistes / prerequites in the non-Windows prerequisite install messages
    • Align Linux spelling with the existing Windows branch wording
  • Example

    combined_prerequisites = " && ".join(install_prerequisites)
    helix_pre_commands += [
        'echo "** Installing prerequisites **"',
        f"{combined_prerequisites} || export PERF_PREREQS_INSTALL_FAILED=1",
        'test "x$PERF_PREREQS_INSTALL_FAILED" = "x1" && echo "** Error: Failed to install prerequisites **"'
    ]

Copilot AI review requested due to automatic review settings July 30, 2026 16:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot AI review requested due to automatic review settings July 30, 2026 16:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot AI changed the title [WIP] Fix code based on review comment 3677953411 Fix Linux prerequisite typo spellings in pre-commands Jul 30, 2026
Copilot AI requested a review from DrewScoggins July 30, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants