fix: ToC toggle overlap and sticky title bleed-through - #53
Merged
Conversation
- sticky ToC title lost its opaque background, letting scrolled headings show through behind it - ToC toggle position used window.innerWidth (includes the scrollbar) instead of document.documentElement.clientWidth, pushing it into the sidebar by the scrollbar's own width - .md-grid only got its extra clearance margin from 76.25em up, but the ToC toggle is offered from 60em, leaving it nowhere to sit at narrower widths where the ToC sidebar sat flush against the edge - .md-content__inner's 70ch min-width ignored the column width the sidebars already shrank it to, overflowing into the ToC sidebar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.innerWidth(includes scrollbar) instead ofdocument.documentElement.clientWidth, pushing it into the sidebar.md-gridclearance margin only applied from 76.25em up, but the ToC toggle is offered from 60em, leaving no room at narrower widths.md-content__inner's 70ch min-width ignored the sidebar-shrunk column width, overflowing into the ToC sidebarTest plan