Skip to content

feature/split-on-payments - #10

Merged
dphoria merged 4 commits into
masterfrom
feature/split-on-payments
Aug 18, 2025
Merged

feature/split-on-payments#10
dphoria merged 4 commits into
masterfrom
feature/split-on-payments

Conversation

@dphoria

@dphoria dphoria commented Aug 18, 2025

Copy link
Copy Markdown
Owner
  • Removed distribute.*
  • Items <-> Extras

dphoria added 4 commits August 3, 2025 18:14
@dphoria
test binary data
2fb5f9b
@dphoria
Merge branch 'master' of https://github.com/dphoria/bill
0842825
@dphoria
Squashed commit of the following:
33670e4 
commit dc26094e5b287ab20d43e10efe5933043bf16887
Author: Sung Cho <sung.w.cho@pm.me>
Date:   Sun Aug 17 21:10:43 2025 -0700

    update person total display

commit bedf9efe5976dd69e3e7399231ffb81240015d7e
Author: Sung Cho <sung.w.cho@pm.me>
Date:   Sun Aug 17 21:02:27 2025 -0700

    shared items highlighted on initial load

commit 583dc721717cddc9363a931193d7bca65ab9f197
Author: Sung Cho <sung.w.cho@pm.me>
Date:   Sun Aug 17 20:56:25 2025 -0700

    animatino during openai api

commit 9a786368c0f7409ef6fd1a5751362624e4252c2e
Author: Sung Cho <sung.w.cho@pm.me>
Date:   Sun Aug 17 20:44:01 2025 -0700

    skip distribute

commit 9d51687
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 05:41:34 2025 +0000

    Fix TypeScript compilation errors by renaming duplicate functions in payments.ts

commit ab33932
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 05:39:01 2025 +0000

    Checkpoint before follow-up message

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit af270c8
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 05:13:59 2025 +0000

    Revert distribute files to master branch state

commit 04d7853
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 05:08:12 2025 +0000

    Simplify test_person_update_item by removing redundant comments

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 54d1529
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 05:04:46 2025 +0000

    Add test for Person.update_item() method with toggle functionality

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 7250184
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 00:58:07 2025 +0000

    Refactor item management methods to prevent duplicates and handle errors

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit de37314
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 00:56:40 2025 +0000

    Enhance docstrings for Person methods with detailed parameter descriptions

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 3dcb737
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 00:55:30 2025 +0000

    Add item management methods to Person class and simplify share_item logic

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit ea7088f
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 00:50:28 2025 +0000

    Refactor payments view to use new calculator method for person shares

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 778378f
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 00:47:29 2025 +0000

    Add person subtotal and total to share item response

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit ff58c2d
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 00:40:50 2025 +0000

    Simplify item sharing logic by removing redundant sharing flag

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 31b8c18
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 00:38:31 2025 +0000

    Remove unnecessary comments in payments UI code

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 32d5c66
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 00:37:06 2025 +0000

    Add interactive item sharing with dynamic UI updates

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 2fcccbb
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 00:34:46 2025 +0000

    Simplify share_item logic by removing redundant index check

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 98c7f87
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sun Aug 10 00:32:37 2025 +0000

    Add route to share/unshare payment items between persons

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 3834da1
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sat Aug 9 19:35:37 2025 +0000

    Remove distribute_item function from payments page

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 09c1a62
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sat Aug 9 19:05:35 2025 +0000

    Refactor item distribution to use Calculator for precise share calculation

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 4d06333
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sat Aug 9 18:59:43 2025 +0000

    Add Calculator initialization with empty extras in distribute_item

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit efb86e1
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sat Aug 9 18:42:27 2025 +0000

    Remove total_distributed calculation from item distribution response

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit df2e8e7
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sat Aug 9 16:23:44 2025 +0000

    Add distribute_item endpoint for splitting bill item among people

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 1f14845
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sat Aug 9 16:16:48 2025 +0000

    Refactor get_person_shares to use lazy evaluation with map

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 1c02d92
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sat Aug 9 16:14:44 2025 +0000

    Modify get_person_shares to return item-share tuples instead of just shares

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit c008ad8
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sat Aug 9 16:09:13 2025 +0000

    Add method to get individual person's shares across all items

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 4f11899
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Sat Aug 9 15:48:21 2025 +0000

    Simplify person items rendering and filtering logic

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 8cbdade
Merge: 6b018d9 ee70dcd
Author: Sung Cho <60983962+dphoria@users.noreply.github.com>
Date:   Sat Aug 9 21:29:33 2025 -0700

    Merge branch 'master' into feature/split-list

commit 6b018d9
Author: Sung Cho <60983962+dphoria@users.noreply.github.com>
Date:   Sat Aug 9 21:23:40 2025 -0700

    bugfix/action-commit (#7)

    * fix: add explicit permissions to lint-format workflow to resolve authentication issues

    * test fix

    ---------

    Co-authored-by: GitHub Action <action@github.com>

commit 4e61eb1
Author: Sung Cho <60983962+dphoria@users.noreply.github.com>
Date:   Sat Aug 9 20:52:51 2025 -0700

    feature/actions (#6)

    * feature/pull-request-actions (#3)

    * feat: Add GitHub Actions for pull request checks

    - Create feature/pull-request-actions branch
    - Add comprehensive CI workflow with tests, linting, and security checks
    - Add pull request workflow for basic quality checks
    - Add security workflow for vulnerability scanning
    - Update pyproject.toml with additional dev and security dependencies
    - Update README with development workflow documentation
    - Configure PDM for dependency management
    - Set up ruff, black, pytest, bandit, and safety checks

    * chore: Update lock file with security dependencies

    * refactor: Consolidate GitHub Actions into single comprehensive workflow

    - Remove redundant pull-request.yml and security.yml files
    - Consolidate all checks into single ci.yml workflow
    - Add conditional job execution for optimized performance
    - Quick checks for PRs, full suite for main branch
    - Update README to reflect simplified approach

    * simplify: Remove lint and security jobs from GitHub Actions

    - Remove lint job (ruff format, isort checks)
    - Remove security job (bandit, safety scans)
    - Keep only quick-checks and test jobs
    - Update README to reflect simplified workflow
    - Streamline local development instructions

    * feat: Make test job run only on manual triggers

    - Add conditional 'if: github.event_name == workflow_dispatch' to test job
    - Test job now only runs when manually triggered
    - Pull requests only run quick checks (Ruff + Black)
    - Update README to reflect new behavior

    * revert: Restore README.md to original state

    - Remove all GitHub Actions documentation
    - Remove development workflow instructions
    - Restore original README content

    * feat: Add pytest to quick-checks job

    - Add pytest step to quick-checks job for pull requests
    - Exclude test_receipt_analysis_with_chat test that calls OpenAI API
    - Use -k 'not test_receipt_analysis_with_chat' to skip the API test
    - All other tests (15/16) run successfully in quick checks

    * fix: Add ruff configuration to resolve CI failures

    - Add comprehensive ruff configuration to pyproject.toml
    - Use modern lint section syntax to avoid deprecation warnings
    - Ignore import sorting issues (I001) to focus on code quality
    - Ignore other style issues that don't affect functionality
    - Ensure consistent behavior between local and CI environments

    * fix: Simplify ruff configuration to resolve CI issues

    - Reduce ruff rules to only essential error checking (E, W, F)
    - Remove complex rules that might cause version compatibility issues
    - Keep only basic pycodestyle errors, warnings, and pyflakes
    - Ignore only line length issues (E501) which are handled by black

    * fix: Use pdm sync instead of pdm install in GitHub Actions

    - Change pdm install to pdm sync to ensure all dependencies are installed
    - pdm sync installs all groups including dev dependencies (ruff, black, pytest)
    - pdm install only installs main dependencies by default
    - This should resolve the 'ruff command not found' error in CI

    * fix: Add dev group to lockfile and update GitHub Actions

    - Add dev group to pdm.lock so dev dependencies can be installed
    - Update GitHub Actions to explicitly install dev group with --group dev
    - Add pdm list command for debugging to see what's installed
    - This should resolve the missing ruff and other dev tools in CI

    * test binary data

    ---------

    Co-authored-by: Cursor Agent <cursoragent@cursor.com>

    * feat: add manual lint-format-write GitHub Action workflow (#5)

    Co-authored-by: Cursor Agent <cursoragent@cursor.com>

    ---------

    Co-authored-by: Cursor Agent <cursoragent@cursor.com>

commit f605516
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Fri Aug 8 19:55:33 2025 +0000

    Refactor item share calculation using map and list comprehension

    Co-authored-by: swc.pub <swc.pub@pm.me>

commit 83bea44
Author: Cursor Agent <cursoragent@cursor.com>
Date:   Fri Aug 8 19:49:52 2025 +0000

    Refactor distribute page to support per-person item distribution

    Co-authored-by: swc.pub <swc.pub@pm.me>
@dphoria
fixed tests
9f2cd29
@dphoria dphoria self-assigned this Aug 18, 2025
@dphoria
dphoria marked this pull request as ready for review August 18, 2025 04:32
@dphoria
dphoria merged commit 6333407 into master Aug 18, 2025
2 checks passed
@dphoria
dphoria deleted the feature/split-on-payments branch August 18, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dphoria dphoria

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dphoria