Skip to content

admin/sync - #8

Closed
dphoria wants to merge 2 commits into
feature/split-listfrom
master
Closed

admin/sync#8
dphoria wants to merge 2 commits into
feature/split-listfrom
master

Conversation

@dphoria

@dphoria dphoria commented Aug 10, 2025

Copy link
Copy Markdown
Owner

No description provided.

dphoria and others added 2 commits August 9, 2025 19:33
* feat: Add GitHub Actions for pull request checks

- Create feature/pull-request-actions branch
- Add comprehensive CI workflow with tests, linting, and security checks
- Add pull request workflow for basic quality checks
- Add security workflow for vulnerability scanning
- Update pyproject.toml with additional dev and security dependencies
- Update README with development workflow documentation
- Configure PDM for dependency management
- Set up ruff, black, pytest, bandit, and safety checks

* chore: Update lock file with security dependencies

* refactor: Consolidate GitHub Actions into single comprehensive workflow

- Remove redundant pull-request.yml and security.yml files
- Consolidate all checks into single ci.yml workflow
- Add conditional job execution for optimized performance
- Quick checks for PRs, full suite for main branch
- Update README to reflect simplified approach

* simplify: Remove lint and security jobs from GitHub Actions

- Remove lint job (ruff format, isort checks)
- Remove security job (bandit, safety scans)
- Keep only quick-checks and test jobs
- Update README to reflect simplified workflow
- Streamline local development instructions

* feat: Make test job run only on manual triggers

- Add conditional 'if: github.event_name == workflow_dispatch' to test job
- Test job now only runs when manually triggered
- Pull requests only run quick checks (Ruff + Black)
- Update README to reflect new behavior

* revert: Restore README.md to original state

- Remove all GitHub Actions documentation
- Remove development workflow instructions
- Restore original README content

* feat: Add pytest to quick-checks job

- Add pytest step to quick-checks job for pull requests
- Exclude test_receipt_analysis_with_chat test that calls OpenAI API
- Use -k 'not test_receipt_analysis_with_chat' to skip the API test
- All other tests (15/16) run successfully in quick checks

* fix: Add ruff configuration to resolve CI failures

- Add comprehensive ruff configuration to pyproject.toml
- Use modern lint section syntax to avoid deprecation warnings
- Ignore import sorting issues (I001) to focus on code quality
- Ignore other style issues that don't affect functionality
- Ensure consistent behavior between local and CI environments

* fix: Simplify ruff configuration to resolve CI issues

- Reduce ruff rules to only essential error checking (E, W, F)
- Remove complex rules that might cause version compatibility issues
- Keep only basic pycodestyle errors, warnings, and pyflakes
- Ignore only line length issues (E501) which are handled by black

* fix: Use pdm sync instead of pdm install in GitHub Actions

- Change pdm install to pdm sync to ensure all dependencies are installed
- pdm sync installs all groups including dev dependencies (ruff, black, pytest)
- pdm install only installs main dependencies by default
- This should resolve the 'ruff command not found' error in CI

* fix: Add dev group to lockfile and update GitHub Actions

- Add dev group to pdm.lock so dev dependencies can be installed
- Update GitHub Actions to explicitly install dev group with --group dev
- Add pdm list command for debugging to see what's installed
- This should resolve the missing ruff and other dev tools in CI

* test binary data

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@dphoria dphoria self-assigned this Aug 10, 2025
@dphoria dphoria added the bug Something isn't working label Aug 10, 2025
@dphoria
dphoria marked this pull request as ready for review August 10, 2025 04:26
@dphoria dphoria closed this Aug 10, 2025
@dphoria

dphoria commented Aug 10, 2025

Copy link
Copy Markdown
Owner Author

Resolve conflict on #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant