Update dependency rector/rector to ^2.5.9 - #373
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 97.18% 97.18%
=======================================
Files 6 6
Lines 532 532
=======================================
Hits 517 517
Misses 15 15 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^2.5.8→^2.5.9Release Notes
rectorphp/rector (rector/rector)
v2.5.9: Released Rector 2.5.9Compare Source
Bugfixes 🐛
Class_-only rules (#8217)AstResolverusage onAddParamBasedOnParentClassMethodRector(#8196)RichParsernode visitors via DI factory instead of private property hack (#8215)ClassPropertyAssignToConstructorPromotionRector(#8232)__construct()in anonymous class that extends parent onRemoveEmptyClassMethodRector(#8219)RemoveDeadZeroAndOneOperationRector(#8213)RemoveDefaultValueFromAssignedPropertyRector(#8214)RemoveDefaultValueFromAssignedPropertyRector(#8212)RemoveDefaultValueFromAssignedPropertyRector(#8211)RemoveDefaultValueFromAssignedPropertyRector(#8209)Set changes 🗑️
NullToStrictStringFuncCallArgRectorout of the PHP 8.1 set (#8234)The rule and all its fixtures stay, so it can still be opted into:
->withRules([NullToStrictStringFuncCallArgRector::class])Deprecations 💀
TypeDeclarationDocblocks: 3 data provider docblock rules (#8235)Data provider docblock typing is not relevant to code quality — it increases maintenance cost and decreases readability of the test class.
Deprecated rules:
AddReturnArrayDocblockFromDataProviderParamRectorAddReturnDocblockDataProviderRectorAddParamArrayDocblockFromDataProviderRectorrectorphp/rector-symfony 🎵
push()to its ownRequestStackvariable inPushRequestToRequestStackConstructorRector(#971)isGranted()service calls in controllers inAuthorizationCheckerIsGrantedExtractorRector(#973)Cookiefixture afterNewToStaticCallRectorconfig removal (#974)rector/type-perfect, its rules ship intomasvotruba/type-coverage2.3 now (#972)symfony/configto^8.1(#977)Deprecated:
SimplifyFormRenderingRector(#975)The rule removed the explicit
->createView()call when a form was passed torender():Symfony supports passing the
FormInterfacedirectly, but the shorthand is ambiguous and breaks dynamic forms: forms modified inPRE_SET_DATA/POST_SUBMITlisteners and submitted over AJAX end up with a 422 response and no clear error. Keeping the explicit->createView()call is the reliable form. See symfony/symfony#50542.rectorphp/rector-phpunit 🧪
expectExceptionMessage()rename toTestCase(#735)rectorphp/rector-downgrade-php ⬇️
MHASH_*constants by name inDowngradeHashAlgorithmXxHashRectorto fix PHP 8.5 deprecation (#386)Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.