Add Ctrl-H find-and-replace to CodeMirror question editors - #464
Open
DaleWMyers wants to merge 1 commit into
Open
Add Ctrl-H find-and-replace to CodeMirror question editors#464DaleWMyers wants to merge 1 commit into
DaleWMyers wants to merge 1 commit into
Conversation
Binds Ctrl-H to the replace command in all four CodeMirror editors (controlEditor, setupQtextEditor, setupRandvarEditor, setupKeepcodeEditor). Also adds the missing CodeMirror search/dialog addon files (searchcursor.js, search.js, dialog.js, dialog.css) which were not in the compressed bundle, and fixes solver.js which was clobbering controlEditor extraKeys on init. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
|
Thanks for this. I won't be able to review this for a few weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binds Ctrl-H to the replace command in all four CodeMirror editors (controlEditor, setupQtextEditor, setupRandvarEditor, setupKeepcodeEditor). Also adds the missing CodeMirror search/dialog addon files (searchcursor.js, search.js, dialog.js, dialog.css) which were not in the compressed bundle, and fixes solver.js which was clobbering controlEditor extraKeys on init.
Note, if the cursor is outside of Common Control or Question Text, Chrome, Firefox, and Edge will send you to their search history. But, if the cursor is in Common Control or Question Text, you will get a two-step find and replace dialogue.