Fix/ebs device resolve retry#4002
Merged
r4victor merged 2 commits intoJul 6, 2026
Merged
Conversation
r4victor
approved these changes
Jul 6, 2026
r4victor
left a comment
r4victor
left a comment
Collaborator
There was a problem hiding this comment.
Tested it fixes #4002 on AWS. Theoretically, the same bug is possible on other backends so ideally the retry logic should be outside of GetRealDeviceName, not inside. But currently we support only GCP shim-attached volumes besides AWS, and it's not reproducible on GCP. Otherwise the PR is good so merging it as is for now.
Collaborator
|
@james-boydell, thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4001
GetRealDeviceNameranlsblkonce and hard-failed with "volume not found among block devices" if the device wasn't there yet. ButAttachVolumereturning success doesn't mean the guest kernel has enumerated the NVMe device, so resolving right after attach intermittently failed. This polls for the device (30s timeout, 500ms interval) instead of failing on the first miss. Threadsctxthrough the backend interface so retries log toshim.log.