feat(readrift): optimize initial load - #2944
Open
matthewsong18 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Initial load (populating the chapter list) for a novel with 300 chapters took around 21 seconds, which is pretty bad. Mb guys.
Solution:
I originally copied the ToC pagination amount of 10, but by pinging the server, turns out the limit is actually 30. I also made the delay between requests a bit smaller at 150 to 250 ms with a jitter compared to the original 300 ms.
Overall, 64.52% less requests and initial load is around 3 times faster.