Contextual/DuckAi: Suggested prompt UI improvements - #9536
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f96ee93 to
6ee7b9b
Compare
66ddd9e to
1cf76e9
Compare
6ee7b9b to
59be903
Compare
1cf76e9 to
78e492f
Compare
59be903 to
a289f69
Compare
c557067 to
1f3bbf9
Compare
a289f69 to
4d75b22
Compare
1f3bbf9 to
3f1ad19
Compare
4d75b22 to
729ad71
Compare
3f1ad19 to
a7e0020
Compare
85d7a3a to
a1fbd03
Compare
be6106a to
b0d1731
Compare
a1fbd03 to
8084207
Compare
|
Found a possible regression with the flag off: When I close the sheet and reopen it does not load the previous chat, it starts a new one. Verified that this behaves differently on internal build. This doesn’t happen always. So it could be already existing on develop but couldn’t reproduce it there I can reproduce it constantly on the branch. Branch behaviour: branch.mp4Develop Behaviour: Develop.mp4This also impacts:
|
|
PR Description nit: The flag is |
Give the redesign-ON entry dialog's suggestion chips and quick-action pill a dedicated duck_ai_suggested_prompts_background (surface fill, 1dp container-coloured border, 20dp corners). The background is scoped to the contextual sheet redesign via a suggestionBackground attribute on ContextualSuggestionsView, so the legacy native sheet keeps the original duck_ai_prompt_background. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
b0d1731 to
048b037
Compare
8084207 to
fac724e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fac724e. Configure here.
| android:drawablePadding="@dimen/keyline_2" | ||
| android:padding="@dimen/keyline_2" | ||
| android:paddingVertical="@dimen/keyline_2" | ||
| android:paddingHorizontal="@dimen/keyline_3" |
There was a problem hiding this comment.
Shared padding leaks past redesign
Low Severity
Padding on suggested prompt chips was updated in the shared item_contextual_suggestion layout, but the new chip chrome is opt-in via suggestionBackground. With contextualSheetRedesign off, DuckChatContextualFragment still uses the old background while chips pick up the new padding, and contextualPromptQuickAction there still uses the previous padding, so sibling chips no longer match.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit fac724e. Configure here.



Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671677432066/task/1217362081874312?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
UI changes (match https://www.figma.com/design/JPmFyhhOHdgfYl5n8uShpU/O-J-Contextual-Duck.ai-Improvements?node-id=406-22221&m=dev)
Steps to test this PR
contextualRedesign FF OFF (Default) - verify no regression
contextualRedesign FF ON (Enable via FF inventory + restart app)
contextualRedesign FF ON + other controls
Note
Low Risk
UI-only drawable and layout tweaks for suggestion chips; no logic, auth, or data-handling changes.
Overview
Updates Duck.ai contextual suggested-prompt chips to match design: 20dp corners, a 1dp border, and slightly wider horizontal padding.
Adds a new
duck_ai_suggested_prompts_backgrounddrawable and asuggestionBackgroundattr onContextualSuggestionsViewso the entry sheet can use the new chip style while other usages keepduck_ai_prompt_background. The same background and padding apply to the summarize quick action.Reviewed by Cursor Bugbot for commit fac724e. Bugbot is set up for automated code reviews on this repo. Configure here.