[DO NOT MERGE YET] Set Metro as the default DI - #9561
Open
landomen wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1217192951849245?focus=true
Tech Design URL (if applicable): N/A
API Proposals URL(s) (if applicable): N/A
Description
Sets Metro as the default DI framework.
Steps to test this PR
Should already be covered by all the CI checks we run alongside Anvil.
UI changes
N/A
Note
High Risk
Changes the default dependency-injection stack for the whole app, so local and any un-overridden builds now compile and wire with Metro instead of Anvil/Dagger.
Overview
Flips
ddg.diingradle.propertiesso Metro is the default DI framework instead of AnvilDagger.CI still passes
-Pddg.diper matrix, so this mainly affects local builds and any jobs that do not override the property. Intended to land only after 5.293.0 is fully rolled out.Reviewed by Cursor Bugbot for commit afa85c4. Bugbot is set up for automated code reviews on this repo. Configure here.