DRM Policy: Add pixels - #9564
Merged
Merged
Conversation
0nko
force-pushed
the
feature/ondrej/drm-policy-pixels
branch
from
August 20, 2026 23:12
a60bdbc to
f8ef345
Compare
0nko
force-pushed
the
feature/ondrej/drm-policy-pixels
branch
from
August 20, 2026 23:15
f8ef345 to
70cef02
Compare
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1217701699737477 |
0nko
force-pushed
the
feature/ondrej/drm-policy-pixels
branch
2 times, most recently
from
August 21, 2026 12:08
38089ab to
a3b9c5b
Compare
0nko
force-pushed
the
feature/ondrej/drm-policy-pixels
branch
from
August 21, 2026 12:51
a3b9c5b to
7f13ba0
Compare
anikiki
approved these changes
Aug 21, 2026
anikiki
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I'll approve, but check this https://app.asana.com/1/137249556945/task/1217678542848175/comment/1217730625247666?focus=true
0nko
force-pushed
the
feature/ondrej/drm-policy-pixels
branch
from
August 22, 2026 11:24
db6fd61 to
dee4427
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1217678542848175?focus=true
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1207418217763355/task/1216952383692269?focus=true
Description
This PR adds a pixel to measure the auto-approved DRM permissions.
Steps to test this PR
Setup
Test privacy config URL: https://gist.githubusercontent.com/0nko/6ba6564e43ec35095a08c0e2288bbdde/raw/3eb9c38d461e73739ebc0d84f7c352cb9d7082d1/privacyconfig.json ("foxnews.com" in eme and "reference.dashif.org" in emeBlock)
Pixel fires for an allow-list grant (test config)
https://www.foxnews.com/videoaction=GRANT, reason=ALLOW_LISTPixel sent: m_site_permissions_auto_granted with params: {type=drm, reason=allow_list}Pixel fires for a protections-off grant (test config)
https://reference.dashif.org/dash.js/latest/samples/drm/widevine.htmland confirmreason=BLOCK_LISTaction=GRANT, reason=PROTECTIONS_OFFandPixel sent: m_site_permissions_auto_granted with params: {type=drm, reason=protections_off}No pixel for user-driven grants
action=GRANT, reason=USER_ALLOW_ALWAYSm_site_permissions_auto_grantedpixel is sent — the user made this choice, it is not an automatic grantNote
Low Risk
Telemetry and feature-flag default/annotation tweaks only; DRM grant behavior is unchanged.
Overview
Adds
m_site_permissions_auto_grantedso DRM grants from the central policy (allow-list or protections-off) can be compared with dialog impressions.The pixel fires once per tab/domain via
DrmSessionStore.markAutoGrantReported. User-driven grants (USER_ALLOW_ALWAYS) and non-GRANT decisions are not counted.Also switches
drmPolicy/centralPolicyto@InternalAlwaysEnabledwith a default ofFALSE.Reviewed by Cursor Bugbot for commit dee4427. Bugbot is set up for automated code reviews on this repo. Configure here.