Skip to content

AD CI #9570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daotuananh1999tgdd-sudo wants to merge 2 commits into
base: develop
Choose a base branch
from
+26 −0
Open

AD CI #9570

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3bb71f
Create android.yml
daotuananh1999tgdd-sudo Aug 21, 2026
575360e
Merge branch 'duckduckgo:develop' into develop
daotuananh1999tgdd-sudo Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Android CI

on:
push:
branches: [ "develop" ]
pull_request:
branches: [ "develop" ]

jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

@cursor cursor Bot Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout omits required submodules

High Severity

actions/checkout@v4 runs without submodules: recursive. Native sources under bloom_cpp (used by httpsupgrade-impl) live in a git submodule, so a full ./gradlew build will fail when compiling that module. Existing Gradle workflows always check out submodules recursively.

Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 575360e. Configure here.

- name: set up JDK 11
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'temurin'
cache: gradle

@cursor cursor Bot Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI uses wrong JDK version

High Severity

This workflow hardcodes JDK 11, but the project expects JDK 21 via .github/.java-version. AGP 8.13.2 needs JDK 17+, and the Metro plugin requires JVM 21 to load, so ./gradlew build will fail on every run. Other workflows already use java-version-file: .github/.java-version.

Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 575360e. Configure here.


- name: Grant execute permission for gradlew
run: chmod +x gradlew
- name: Build with Gradle
run: ./gradlew build