fix(pir): forward CAPTCHA parent scope - #9571
Open
madblex wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Asana: https://app.asana.com/1/137249556945/task/1217675906074658
This PR:
parentto both Android CAPTCHA action models, because Android drops broker fields that the Kotlin models do not declare.getCaptchaInfoandsolveCaptcha. Android only forwards the field, while content-scope-scripts handles the matching and CAPTCHA logic.Note
Low Risk
Small PIR model/serialization change so an existing broker field is no longer stripped. No new CAPTCHA or matching logic on Android.
Overview
Stops Android from dropping broker
parenton CAPTCHA actions so content-scope-scripts can scopegetCaptchaInfoandsolveCaptchato the matched profile row.Adds optional
parentonGetCaptchaInfoandSolveCaptcha(sameParentElementused by form selectors). The native layer only deserializes and forwards the field; matching and CAPTCHA handling stay in C-S-S. A processor test checksprofileMatchis pushed through for both action types.Reviewed by Cursor Bugbot for commit cfa62d6. Bugbot is set up for automated code reviews on this repo. Configure here.