Skip to content

Fix: Lingering DRM dialog when Learn more link clicked - #9575

Open
0nko wants to merge 2 commits into
feature/ondrej/drm-policy-pixelsfrom
feature/ondrej/drm-dialog-link
Open

Fix: Lingering DRM dialog when Learn more link clicked#9575
0nko wants to merge 2 commits into
feature/ondrej/drm-policy-pixelsfrom
feature/ondrej/drm-dialog-link

Conversation

@0nko

@0nko 0nko commented Aug 21, 2026

Copy link
Copy Markdown
Member

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1217714992339528?focus=true

Description

This PR solves an issue when the DDG is the default browser and a user clicks on the DRM dialog's Learn more link, which leaves the DRM dialog open on top of the wrong tab.

Steps to test this PR

  • Set DDG as a default browser
  • Load some site that displays a DRM dialog (https://reference.dashif.org/dash.js/latest/samples/drm/widevine.html)
  • Tap on the "Learn more" link
  • Notice the dialog is dismissed when the website is loaded

Note

Low Risk
Small UX fix in the DRM permission dialog click path; it now denies the in-session request when Learn more is opened, with no auth or persistence changes.

Overview
Fixes the DRM site-permission dialog lingering over a new tab when the user taps Learn more while DuckDuckGo is the default browser.

The Learn more click handler now dismisses the dialog and denies the pending DRM request before opening the help URL, so the permission prompt is not left unanswered on the original page. Adds a Robolectric test (with Android resources enabled for the module) covering that path.

Reviewed by Cursor Bugbot for commit a93a27e. Bugbot is set up for automated code reviews on this repo. Configure here.

@0nko
0nko requested a review from anikiki August 21, 2026 12:21

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1a0fd2f. Configure here.

@0nko
0nko force-pushed the feature/ondrej/drm-dialog-link branch from 1a0fd2f to 2ba99cd Compare August 21, 2026 12:51

@anikiki anikiki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

@anikiki anikiki self-assigned this Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants