Conversation
|
|
||
| describe "semaphore without staleness checking" do | ||
| let(:semaphore) { Redis::Semaphore.new(:my_semaphore, :redis => @redis) } | ||
| let(:semaphore2) { Redis::Semaphore.new(:my_semaphore, :redis => @redis) } |
Collaborator
There was a problem hiding this comment.
Use the new Ruby 1.9 hash syntax.
Contributor
Author
|
All the comments of Hound are targeted at code that has been there before. I'd rather not obey Hound in this pull request to keep the changes simple for the review. @dv: If you want me to, I will change the name of the inner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shall fix #45.
Instead of only checking for the tokens that the current instance knows about, the tokens are fetched from Redis in the
locked?method.