Fix C4244 warning in Win32 builds when converting streamoff to size_t - #33
Merged
Merged
Conversation
umasagarmd
force-pushed
the
fix/c4244-streamoff-to-size_t
branch
from
August 17, 2026 21:17
2a32f01 to
80a84fc
Compare
|
Owner
|
Thank you! |
Owner
|
Failing tests are on me, it's Sonar actions needing effort on my part. I'll deal with it. |
Author
|
Hi @dwd, thanks again for looking into the CI issues. Do you have an estimated timeline for when this PR might be ready to move forward? Thanks! |
Owner
|
I've merged it, will need to fix the pipeline later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MSVC warning C4244 in Win32 builds:
In utils.h, the line:
size_t size = stream.tellg();
causes MSVC warning C4244 ('initializing': conversion from 'std::streamoff' to 'size_t', possible loss of data).
Make the conversion explicit and use auto for type deduction:
auto size = static_cast<size_t>(stream.tellg());