refactor: retarget samples to the reclaimed enum names - #23
Open
TimPurdum wants to merge 1 commit into
Open
Conversation
The superseded owner-prefixed enum twins are retired in Core and Pro, so these pages now use the friendly names: ColorRampAlgorithm -> Algorithm, FeatureFormGroupDisplay -> GroupDisplay, RequestOptionsResponseType -> ResponseType, SketchCreationMode -> CreationMode, FieldInfoFormatDateFormat -> DateFormat, FieldInfoStringFieldOption -> StringFieldOption. Members are identical in every pair, so behavior is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B9vty19AZZNJmoTug6zr94
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retargets 13 sample pages onto the reclaimed enum names from CodeGen #77. No behavior change: every rename is a one-for-one swap to the survivor of an identical enum pair.
Merge order matters. This has to land with GeoBlazor.Core PR #11 and GeoBlazor.Pro PR (feature/enum-wire-literals) — the old names do not exist after those merge, so samples stop compiling if this is left behind.
What changed
21 identifier substitutions across
WCSLayers,ImageryGroupBlend,ApplyEdits,UpdateFeatureAttributes,SearchCustomSource,HighlightFeaturesByGeometry,LengthAndArea,SketchQuery,CSVLayers,GeoJSONLayers,Popups,Binning, andClustering.Examples:
FieldInfoFormatDateFormat->DateFormat,FieldInfoStringFieldOption->StringFieldOption,SketchCreationMode->CreationMode,ColorRampAlgorithm->Algorithm.Nullable-typed properties needed
Enums.qualification, because the C# "Color Color" rule that lets a bareDateFormatresolve does not apply throughNullable<T>.Verification
dotnet buildclean at 0 errors for both sample projects, built with-p:UseProjectReferences=trueso they compile against the branch rather than published NuGet.