all: remove zcallback_*.s from the external code list - #496
Merged
hajimehoshi merged 2 commits intoAug 12, 2026
Conversation
The files were renamed from zcallback_darwin_GOARCH.s to zcallback_GOARCH.s in ebitengine#98, but the external code list still refers to the old names.
hajimehoshi
reviewed
Aug 12, 2026
NotAFlightRisk
changed the title
hajimehoshi
approved these changes
Aug 12, 2026
hajimehoshi
left a comment
hajimehoshi
left a comment
Member
There was a problem hiding this comment.
LGTM
@TotallyGamerJet PTAL
Contributor
Author
|
Cheers @hajimehoshi :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
None, spotted it while working out which bits came from the Go runtime.
What type of issue is this addressing?
bug (well, not really - just a small docs issue)
What this PR does | solves
The external code list points atzcallback_darwin_*.s, but those got renamed tozcallback_<GOARCH>.sin #98 when darwin and linux were merged, so the entry doesn't name a file that exists any more. Every other entry in the list still resolves, so this is the only one.Turns out the line never attributed anything, the files are generated locally by
wincallback.gowhich is already listed. Dropping it instead, thanks @hajimehoshi.