Fix MAX fan control on M1–M4 Apple Silicon - #2
Open
HerbertGao wants to merge 1 commit into
Open
Conversation
HerbertGao
marked this pull request as ready for review
August 1, 2026 09:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Apple Silicon MAX mode on M1–M4 machines by acquiring the
Ftstfan-control gate before writing per-fan manual mode and target RPM keys.The previous implementation attempted
F%dmd = 1directly, swallowed mode-write failures, and then wroteF%dTg. On an M1 Max this leftthermalmonitordin control, so MAX remained near idle RPM even though the UI reported the fan as managed.Changes
Ftstgate;Ftstbefore per-fan manual mode when present;Ftst;Ftst, mode, and target writes with bounded delays;Ftstwhen returning M1–M4 hardware to System control.Scope
This PR intentionally changes only
AppleSiliconSMC.swift. Broader lifecycle/state-machine changes discovered during review were kept out of this patch and proposed separately in #1.Validation
swift test --package-path SMCKit— 13 tests passedxcodebuild build -project CoolMyMac-App/CoolMyMac.xcodeproj -scheme CoolMyMac-Daemon -configuration Debug ONLY_ACTIVE_ARCH=YES CODE_SIGNING_ALLOWED=NO— passedgit diff --check— passedHardware validation status
The original failure was reproduced on MacBookPro18,2 / M1 Max. Final privileged daemon validation still needs a build signed with the upstream project's team identity, so this PR is opened as draft.