Conversation
# Conflicts: # config/environments/production.rb # config/initializers/action_mailer_ses.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
mainup to date withdevelop-mainis currently missing all of this work, which is why the deployed ECS task is crash-looping (the SES boot-order fix included here is what actually resolves that).LoadBigSamJobreliability pass: per-row transactions with rollback on failure, structured error/skip reporting instead of silently swallowed rescues, fixed several confirmed bugs found by auditing against the real production spreadsheet (case-sensitive flag columns, duplicate repository/collection labels, a copy-paste bug wiring the wrong collection to the third repository slot, a dead notes-field typo, aNoMethodErrorthat could crash the whole job on certain recipient names, and blank spreadsheet IDs silently colliding into one letter record)LoadBigSamJob#dry_run- runs the full pipeline and reports what would happen without persisting anything or touching Elasticsearchprocess_letterinto focused methods; the three near-duplicate repository/collection blocks collapsed into one table-driven methodBigSamMailerses_settings=NoMethodError) currently crashing the ECS taskTest plan
develop(job, mailer, model specs - 50 examples)RAILS_ENV=productionand confirmingActionMailer::Base.delivery_method/ses_settingsresolve without errormainafter merge and confirm the task boots pastdb:migrate