Skip to content

First version of new API for Launch Manager - #377

Merged
MaciejKaszynski merged 6 commits into
eclipse-score:mainfrom
etas-contrib:feature/new-public-api-for-lm
Aug 7, 2026
Merged

First version of new API for Launch Manager#377
MaciejKaszynski merged 6 commits into
eclipse-score:mainfrom
etas-contrib:feature/new-public-api-for-lm

Conversation

@SimonKozik

Copy link
Copy Markdown
Contributor

First draft of new API for Launch Manager

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 17c04bfd-a269-4e7a-a549-7ce1567430a4
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (33 packages loaded, 10 targets configured)

Analyzing: target //:license-check (82 packages loaded, 10 targets configured)

Analyzing: target //:license-check (140 packages loaded, 842 targets configured)

Analyzing: target //:license-check (158 packages loaded, 5063 targets configured)

Analyzing: target //:license-check (164 packages loaded, 9345 targets configured)

Analyzing: target //:license-check (170 packages loaded, 9397 targets configured)

Analyzing: target //:license-check (170 packages loaded, 9397 targets configured)

INFO: Analyzed target //:license-check (175 packages loaded, 11535 targets configured).
[1 / 1] no actions running
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 26.875s, Critical Path: 2.48s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@paulquiring

Copy link
Copy Markdown
Contributor

It looks like it could work. To see if this if this is the right fit in combination with score::mw::com a test would be good before we switch to this.

@paulquiring
paulquiring self-requested a review July 29, 2026 05:29
@NicolasFussberger

Copy link
Copy Markdown
Contributor

It looks like it could work. To see if this if this is the right fit in combination with score::mw::com a test would be good before we switch to this.

I like this suggestion. Would it be possible to add a dummy details/lm_controlimpl.hpp with a test that just shows how the API interaction would look like from the users perspective?

Comment thread score/launch_manager/src/lm_control/src/fixed_string.hpp
Comment thread score/launch_manager/src/lm_control/src/ilm_control.hpp Outdated
Comment thread score/launch_manager/src/lm_control/src/ilm_control.hpp
Comment thread score/launch_manager/src/lm_control/src/ilm_control.hpp

@pawelrutkaq pawelrutkaq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would fix most of descriptions as they are bloated

Comment thread score/launch_manager/src/lm_control/src/ilm_control.hpp
Comment thread score/launch_manager/src/lm_control/src/ilm_control.hpp
Comment thread score/launch_manager/src/lm_control/src/ilm_control.hpp
Comment thread score/launch_manager/src/lm_control/src/ilm_control.hpp Outdated
Comment thread score/launch_manager/src/lm_control/src/ilm_control.hpp
FScholPer
FScholPer previously approved these changes Aug 5, 2026
@SimonKozik
SimonKozik dismissed stale reviews from NicolasFussberger and FScholPer via f8a846a August 6, 2026 14:03
@SimonKozik
SimonKozik temporarily deployed to workflow-approval August 6, 2026 14:04 — with GitHub Actions Inactive
@SimonKozik
SimonKozik temporarily deployed to workflow-approval August 6, 2026 14:04 — with GitHub Actions Inactive
@SimonKozik
SimonKozik force-pushed the feature/new-public-api-for-lm branch from f8a846a to 460b99d Compare August 7, 2026 08:00
@SimonKozik
SimonKozik temporarily deployed to workflow-approval August 7, 2026 08:00 — with GitHub Actions Inactive
@SimonKozik
SimonKozik temporarily deployed to workflow-approval August 7, 2026 08:00 — with GitHub Actions Inactive
@MaciejKaszynski
MaciejKaszynski merged commit 6a52b5d into eclipse-score:main Aug 7, 2026
20 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants