First version of new API for Launch Manager - #377
Merged
MaciejKaszynski merged 6 commits intoAug 7, 2026
Merged
Conversation
SimonKozik
requested a deployment
to
workflow-approval
July 28, 2026 14:35 — with
GitHub Actions
Waiting
SimonKozik
requested a deployment
to
workflow-approval
July 28, 2026 14:35 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
Contributor
|
It looks like it could work. To see if this if this is the right fit in combination with |
paulquiring
self-requested a review
July 29, 2026 05:29
paulquiring
approved these changes
Jul 29, 2026
FScholPer
reviewed
Jul 29, 2026
pawelrutkaq
self-requested a review
July 29, 2026 08:30
SimonKozik
requested review from
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri and
ramceb
as code owners
July 30, 2026 13:41
SimonKozik
requested a deployment
to
workflow-approval
July 30, 2026 13:41 — with
GitHub Actions
Waiting
SimonKozik
requested a deployment
to
workflow-approval
July 30, 2026 13:41 — with
GitHub Actions
Waiting
Contributor
I like this suggestion. Would it be possible to add a dummy details/lm_controlimpl.hpp with a test that just shows how the API interaction would look like from the users perspective? |
SimonKozik
requested a deployment
to
workflow-approval
July 31, 2026 10:23 — with
GitHub Actions
Waiting
SimonKozik
requested a deployment
to
workflow-approval
July 31, 2026 10:23 — with
GitHub Actions
Waiting
pawelrutkaq
requested changes
Aug 4, 2026
pawelrutkaq
left a comment
Contributor
There was a problem hiding this comment.
I would fix most of descriptions as they are bloated
SimonKozik
requested a deployment
to
workflow-approval
August 5, 2026 07:25 — with
GitHub Actions
Waiting
SimonKozik
requested a deployment
to
workflow-approval
August 5, 2026 07:25 — with
GitHub Actions
Waiting
SimonKozik
requested a deployment
to
workflow-approval
August 5, 2026 09:44 — with
GitHub Actions
Waiting
SimonKozik
requested a deployment
to
workflow-approval
August 5, 2026 09:44 — with
GitHub Actions
Waiting
FScholPer
previously approved these changes
Aug 5, 2026
NicolasFussberger
previously approved these changes
Aug 6, 2026
SimonKozik
dismissed stale reviews from NicolasFussberger and FScholPer
via
August 6, 2026 14:03
f8a846a
SimonKozik
temporarily deployed
to
workflow-approval
August 6, 2026 14:04 — with
GitHub Actions
Inactive
SimonKozik
temporarily deployed
to
workflow-approval
August 6, 2026 14:04 — with
GitHub Actions
Inactive
pawelrutkaq
approved these changes
Aug 7, 2026
SimonKozik
force-pushed
the
feature/new-public-api-for-lm
branch
from
August 7, 2026 08:00
f8a846a to
460b99d
Compare
SimonKozik
temporarily deployed
to
workflow-approval
August 7, 2026 08:00 — with
GitHub Actions
Inactive
SimonKozik
temporarily deployed
to
workflow-approval
August 7, 2026 08:00 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft of new API for Launch Manager