Adding a new ready condition `FileState` by MaciejKaszynski · Pull Request #402 · eclipse-score/lifecycle

MaciejKaszynski · 2026-08-03T08:40:52Z

Adding a new ready condition for file state.

E.g. a component like "setup network" can wait for some /dev/<network file> to make the component active. Then Later components can depend on this.

github-actions · 2026-08-03T08:42:00Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 6c260d4f-651f-44e4-b9fd-c14efd7b8fdc
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (35 packages loaded, 10 targets configured)

Analyzing: target //:license-check (89 packages loaded, 10 targets configured)

Analyzing: target //:license-check (116 packages loaded, 244 targets configured)

Analyzing: target //:license-check (157 packages loaded, 4480 targets configured)

Analyzing: target //:license-check (162 packages loaded, 6249 targets configured)

Analyzing: target //:license-check (167 packages loaded, 6298 targets configured)

Analyzing: target //:license-check (170 packages loaded, 9513 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

INFO: Analyzed target //:license-check (175 packages loaded, 11535 targets configured).
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 26.551s, Critical Path: 2.42s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-08-03T08:54:53Z

The created documentation from the pull request is available at: docu-html

NicolasFussberger · 2026-08-03T09:23:29Z

+                    * **Description:** Specifies the required existence state of the file.
+                    * **Allowed Values:**
+                        * ``"Exists"``: The component is ready when the file at ``file_path`` exists.
+                        * ``"Deleted"``: The component is ready when the file at ``file_path`` is deleted.


Are there any files which cannot be watched via inotify and thus we need to poll for their existence with some to-be-configured interval?

As discussed only containers would be problematic here, and I think for now since we do not support containers anyways I don't think we should support this yet. I think in the future we could have an optional polling_rate var that when set would switch to using polling but don't think it makes sense to pay so much of a slow down to support a very specific scenario.

I agree, support for polling only needs to be added if/when we support containers.

NicolasFussberger · 2026-08-03T09:28:32Z

 {
-    ProcessState process_state{ProcessState::Running};
+    std::optional<ProcessState> process_state{ProcessState::Running};
+    std::optional<FileState> file_state;


I wonder if here or even in the user config we shall introduce some 'type' attribute that defines which type of ready condition is configured/used, or is it intended to support any combinations of these?

"readyCondition" : { "type": "PROCESS_STATE", .... }

For now with just 2 types its probably still manageable as is.
If we introduce more ready conditions, it might get out of hand.

NicolasFussberger · 2026-08-03T09:39:07Z

+  // Absolute path to the file being watched.
+  file_path:string (required); // required
+  // Existence state of the file. Defaults to Exists if not specified.
+  state:FileExistenceState = Exists; // optional, defaults to Exists


Currently, all the default values are in scripts/config_mapping/lifecycle_config.py

I think this mapping is not existing in the PR

The Config also defaults this in https://github.com/eclipse-score/lifecycle/blob/main/score/launch_manager/src/daemon/src/configuration/configuration_adapter.cpp#L175-L198

danth · 2026-08-07T13:28:06Z

+                    * **Description:** Specifies the required existence state of the file.
+                    * **Allowed Values:**
+                        * ``"Exists"``: The component is ready when the file at ``file_path`` exists.
+                        * ``"Deleted"``: The component is ready when the file at ``file_path`` is deleted.


I agree, support for polling only needs to be added if/when we support containers.

danth · 2026-08-07T13:30:39Z

+                    "Exists",
+                    "Deleted"
+                  ],
+                  "pattern": "^/.*",


Looks like this validation was added to the wrong attribute?

If possible we should also test that the validation fails.

danth · 2026-08-07T13:31:07Z

+        case fb::FileExistenceState::Deleted:
+            return FileExistenceState::Deleted;
+        case fb::FileExistenceState::Exists:
+        default:


Suggested change

default:

danth · 2026-08-07T13:35:26Z

+                    }
+                    else if constexpr (std::is_same_v<argT, score::mw::launch_manager::configuration::FileState>)
+                    {
+                        SCORE_LANGUAGE_FUTURECPP_ASSERT_MESSAGE(false, "FileState is not yet supported");


Suggested change

SCORE_LANGUAGE_FUTURECPP_ASSERT_MESSAGE(false, "FileState is not yet supported");

SCORE_LANGUAGE_FUTURECPP_UNREACHABLE_MESSAGE("FileState is not yet supported");

MaciejKaszynski requested review from FScholPer, NicolasFussberger, antonkri, pawelrutkaq and ramceb as code owners August 3, 2026 08:40

github-project-automation Bot added this to LCM - Lifecycle & Health FT Aug 3, 2026

MaciejKaszynski requested a review from anmittag as a code owner August 3, 2026 08:40

github-project-automation Bot moved this to Backlog in LCM - Lifecycle & Health FT Aug 3, 2026

MaciejKaszynski requested a deployment to workflow-approval August 3, 2026 08:40 — with GitHub Actions Waiting

MaciejKaszynski changed the title ~~Adding new config field~~ Adding a new ready condition FileState Aug 3, 2026

NicolasFussberger reviewed Aug 3, 2026

View reviewed changes

Comment thread score/launch_manager/docs/user_guide/configuration.rst

NicolasFussberger reviewed Aug 3, 2026

View reviewed changes

Comment thread score/launch_manager/src/daemon/src/configuration/config_schema/launch_manager.schema.json

NicolasFussberger reviewed Aug 4, 2026

View reviewed changes

Comment thread score/launch_manager/docs/user_guide/configuration.rst

MaciejKaszynski requested a deployment to workflow-approval August 4, 2026 16:02 — with GitHub Actions Waiting

MaciejKaszynski added 3 commits August 7, 2026 11:45

Adding new config field

327924d

Fixing spelling

e2558da

Making only one ready condition valid

90ddedb

MaciejKaszynski force-pushed the new-file-state-config branch from 6d1b659 to 90ddedb Compare August 7, 2026 10:50

MaciejKaszynski requested a deployment to workflow-approval August 7, 2026 10:50 — with GitHub Actions Waiting

Adding polling interval

f9497c6

danth suggested changes Aug 7, 2026

View reviewed changes

MaciejKaszynski requested a deployment to workflow-approval August 7, 2026 13:44 — with GitHub Actions Waiting

MaciejKaszynski requested a deployment to workflow-approval August 7, 2026 14:53 — with GitHub Actions Waiting

Fixing some errors

9f99911

MaciejKaszynski force-pushed the new-file-state-config branch from 053c31b to 9f99911 Compare August 7, 2026 15:44

MaciejKaszynski temporarily deployed to workflow-approval August 7, 2026 15:44 — with GitHub Actions Inactive

MaciejKaszynski deployed to workflow-approval August 7, 2026 15:44 — with GitHub Actions Active

	SCORE_LANGUAGE_FUTURECPP_ASSERT_MESSAGE(false, "FileState is not yet supported");
	SCORE_LANGUAGE_FUTURECPP_UNREACHABLE_MESSAGE("FileState is not yet supported");

Uh oh!

Conversation

MaciejKaszynski commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

NicolasFussberger Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Aug 3, 2026 •

edited

Loading

NicolasFussberger Aug 3, 2026 •

edited

Loading