Fix missed restart - #416
Open
WilliamRoebuck wants to merge 6 commits into
Open
Conversation
WilliamRoebuck
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
August 5, 2026 16:12
WilliamRoebuck
requested a deployment
to
workflow-approval
August 5, 2026 16:12 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 5, 2026 16:12 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
WilliamRoebuck
requested a deployment
to
workflow-approval
August 5, 2026 16:23 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 5, 2026 16:23 — with
GitHub Actions
Waiting
danth
suggested changes
Aug 6, 2026
WilliamRoebuck
requested a deployment
to
workflow-approval
August 6, 2026 11:01 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 6, 2026 11:01 — with
GitHub Actions
Waiting
WilliamRoebuck
force-pushed
the
feature/fix-missed-restart
branch
from
August 7, 2026 08:08
4a2ab08 to
58157c8
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
August 7, 2026 08:08 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 7, 2026 08:08 — with
GitHub Actions
Waiting
WilliamRoebuck
force-pushed
the
feature/fix-missed-restart
branch
from
August 7, 2026 08:22
58157c8 to
59fb748
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
August 7, 2026 08:22 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 7, 2026 08:22 — with
GitHub Actions
Waiting
WilliamRoebuck
force-pushed
the
feature/fix-missed-restart
branch
from
August 7, 2026 08:45
59fb748 to
0a6dc55
Compare
WilliamRoebuck
temporarily deployed
to
workflow-approval
August 7, 2026 08:45 — with
GitHub Actions
Inactive
WilliamRoebuck
force-pushed
the
feature/fix-missed-restart
branch
from
August 7, 2026 08:54
0a6dc55 to
c265cac
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
August 7, 2026 08:54 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 7, 2026 08:54 — with
GitHub Actions
Waiting
MaciejKaszynski
requested changes
Aug 7, 2026
| }, | ||
| "fallback_run_target": { | ||
| "depends_on": [ | ||
| "control_client_mock", |
Contributor
There was a problem hiding this comment.
Do you think it would make sense to add a component_not_crashing and check that it was not restarted?
I think the control_client_mock should work like this but might be a bit difficult to see if it was restarted on not?
Contributor
There was a problem hiding this comment.
Or would a seperate test make sense for this?
|
|
||
| @add_test_properties( | ||
| fully_verifies=[], | ||
| test_type="interface-test", |
Contributor
There was a problem hiding this comment.
I think inspection would make more sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refactor missed the case where a crashed component is restarted by remaining active. Along with the fix, a new integration test has been added for this functionality. Also fixed a bug where the python test runner would greatly exceed the configured timeout.