Add AliveMonitorConfig header - #432
Open
paulquiring wants to merge 1 commit into
Open
Conversation
paulquiring
requested a deployment
to
workflow-approval
August 6, 2026 14:09 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
August 6, 2026 14:09 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
paulquiring
force-pushed
the
alive_monitor_owns_config
branch
from
August 7, 2026 07:57
5a73ffc to
09a29cf
Compare
paulquiring
requested a deployment
to
workflow-approval
August 7, 2026 07:57 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
August 7, 2026 07:57 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
paulquiring
marked this pull request as ready for review
August 7, 2026 08:02
paulquiring
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
August 7, 2026 08:02
MaciejKaszynski
requested changes
Aug 7, 2026
|
|
||
| #include "score/mw/launch_manager/configuration/config.hpp" | ||
|
|
||
| namespace score |
Contributor
There was a problem hiding this comment.
I think we shall use score::mw::lifecycle::internal::alive here?
| { | ||
| std::string name; | ||
| std::optional<score::mw::launch_manager::configuration::ComponentAliveSupervision> alive_supervision; | ||
| uid_t uid{}; |
Contributor
There was a problem hiding this comment.
I think it would be nice to add briefs even it they are obvious. but would need a brief to why uid is needed
| void SetUp() override | ||
| { | ||
| RecordProperty("TestType", "interface-test"); | ||
| RecordProperty("DerivationTechnique", "explorative-testing"); |
Contributor
There was a problem hiding this comment.
Suggested change
| RecordProperty("DerivationTechnique", "explorative-testing"); | |
| RecordProperty("DerivationTechnique", "boundary-values"); |
Contributor
There was a problem hiding this comment.
I think moving this to config component would make more sense. Could be confusing trying to find a config type in alive_moniotr
| @@ -32,7 +31,9 @@ AliveMonitorImpl::AliveMonitorImpl( | |||
| SptrIRecoveryClient recovery_client, | |||
| UptrIProcessStateReceiver process_state_receiver, | |||
Contributor
There was a problem hiding this comment.
Think it should be && so that it is clear we are invalidating the users var
| if (isSupervisedType(comp.component_properties.application_profile.application_type)) | ||
| { | ||
| SupervisedComponentConfig info{}; | ||
| info.name = comp.name; |
Contributor
There was a problem hiding this comment.
I think the name of the component will always be alive for the lifetime of the alive supervision so we can use std::string_view here and remove a string copy.
Contributor
Author
There was a problem hiding this comment.
See Description
"Adds temporary functionality required to copy configuration data until we can, as part of our refactoring efforts, move the configuration data to the entities intended for that purpose."
The copy is intentional. We need to copy because the object referenced will be moved in a later PR to the ProcessInfoNode.
| } | ||
|
|
||
| bool PhmDaemon::construct(const Config& config, const SupervisionBufferConfig& f_bufferConfig_r) noexcept(false) | ||
| bool PhmDaemon::construct(const AliveMonitorConfig& config, const SupervisionBufferConfig& f_bufferConfig_r) noexcept( |
Contributor
There was a problem hiding this comment.
Do you think we could further break down the config?
It seems PhmDaemon only requires the evaluation cycle, so I think we could take as && param and move it here, then somehow move the vector of config into FlatCfgFactory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds temporary functionality required to copy configuration data until we can, as part of our refactoring efforts, move the configuration data to the entities intended for that purpose.