fix: Fall back to mqv:filter when pathname topic is empty - #1550
Open
VedantMadane wants to merge 1 commit into
Open
fix: Fall back to mqv:filter when pathname topic is empty#1550VedantMadane wants to merge 1 commit into
VedantMadane wants to merge 1 commit into
Conversation
- use || so empty pathname falls back to mqv:filter/topic Fixes eclipse-thingweb#1508 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
Member
|
Hi @VedantMadane thank you for your contribution! It seems that you fixed something already covered by #1511. As I wrote there, it would be nice to have tests to avoid regression. Would you mind adding them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fall back to mqv:filter when pathname topic is empty
Changes
Fixes #1508