Remove value wrapping and make CoAP actions return results directly - #43
Open
Nickgraviton wants to merge 1 commit into
Open
Remove value wrapping and make CoAP actions return results directly#43Nickgraviton wants to merge 1 commit into
Nickgraviton wants to merge 1 commit into
Conversation
Contributor
Author
|
@egekorkan could you check if this behavior aligns with node-wot? I removed all wrapping of the form |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to fix #9. All value wrapping has been removed. Clients and tests were rewritten for all protocol bindings (except MQTT/Zenoh that encapsulate message IDs along with the input) to use property writes and action invocation data directly.
Also, fixes #10. CoAP actions no longer receive an ID that can be checked later. The server waits for the invocation to complete and returns the result directly. HTTP was fixed in #36.