feat: adds bottomsheet functionality to albumpage - #922
Conversation
adds items to album_page_menu.xml: - Instant mix - Play Next - Add to Queue and adds identical functionality as to what is currently done in AlbumBottomSheet to AlbumPageFragment strings should probably be unified between album_bottom_sheet_ and menu_ but this isn't currently done so I just added more to menu_ I'm also not sure that mix functionality currently works (seems like it just plays the album??), but logic was directly copied over from the bottom sheet It also seems like there's a minor discrepency between album_bottom_sheet_play_next and download_bottom_sheet_play_next, bottom_sheet_play_next song_bottom_sheet_play_next for french, polish and turkish. I unified them, but I speak none of these languages
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@andOrlando thanks for your contribution! We checked the code and it is better to drop Instant Mix from the feat, Instant Mix has a few more considerations that are better to keep off the scope of this PR. Another important consideration is the usage of an observer. You can check in #926 that I request the value directly instead of registering an observer. This is because This app re-fetches data on UI load, so the action will get re-triggered unexpectedly. |
|
Hi @andOrlando - thanks for the PR. We are holding this one until you can update per @tvillega feedback. We had a hell of a time with observers recently causing havoc so we are keeping a close eye on using them. |
|
Yeah, sorry about that--now that it's the weekend I'll hopefully get the chance to fix my PR |
closes #920
adds items to album_page_menu.xml:
and adds identical functionality as to what is currently done in AlbumBottomSheet to AlbumPageFragment
strings should probably be unified between album_bottom_sheet_ and menu_ but this isn't currently done so I just added more to menu_
I'm also not sure that mix functionality currently works (seems like it just plays the album??), but logic was directly copied over from the bottom sheet
It also seems like there's a minor discrepency between album_bottom_sheet_play_next and download_bottom_sheet_play_next, bottom_sheet_play_next song_bottom_sheet_play_next for french, polish and turkish. I unified them, but I speak none of these languages
before:

after:
