Skip to content

feat: adds bottomsheet functionality to albumpage - #922

Open
andOrlando wants to merge 1 commit into
eddyizm:developmentfrom
andOrlando:feat/queue-album-from-album-page
Open

feat: adds bottomsheet functionality to albumpage#922
andOrlando wants to merge 1 commit into
eddyizm:developmentfrom
andOrlando:feat/queue-album-from-album-page

Conversation

@andOrlando

Copy link
Copy Markdown

closes #920

adds items to album_page_menu.xml:

  • Instant mix
  • Play Next
  • Add to Queue

and adds identical functionality as to what is currently done in AlbumBottomSheet to AlbumPageFragment

strings should probably be unified between album_bottom_sheet_ and menu_ but this isn't currently done so I just added more to menu_

I'm also not sure that mix functionality currently works (seems like it just plays the album??), but logic was directly copied over from the bottom sheet

It also seems like there's a minor discrepency between album_bottom_sheet_play_next and download_bottom_sheet_play_next, bottom_sheet_play_next song_bottom_sheet_play_next for french, polish and turkish. I unified them, but I speak none of these languages

before:
image

after:
image

adds items to album_page_menu.xml:
- Instant mix
- Play Next
- Add to Queue

and adds identical functionality as to what is currently done in AlbumBottomSheet to AlbumPageFragment

strings should probably be unified between album_bottom_sheet_ and menu_ but this isn't currently done so I just added more to menu_

I'm also not sure that mix functionality currently works (seems like it just plays the album??), but logic was directly copied over from the bottom sheet

It also seems like there's a minor discrepency between album_bottom_sheet_play_next and download_bottom_sheet_play_next, bottom_sheet_play_next song_bottom_sheet_play_next for french, polish and turkish. I unified them, but I speak none of these languages
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ff592a0f-5295-4ac2-843b-10a1a130e504

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tvillega

Copy link
Copy Markdown
Contributor

@andOrlando thanks for your contribution!

We checked the code and it is better to drop Instant Mix from the feat, Instant Mix has a few more considerations that are better to keep off the scope of this PR.

Another important consideration is the usage of an observer. You can check in #926 that I request the value directly instead of registering an observer. This is because bottomsheet is an UI element that gets build and destroyed, while the overflow button is persistent and starts stacking observers.

This app re-fetches data on UI load, so the action will get re-triggered unexpectedly.

@eddyizm

eddyizm commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Hi @andOrlando - thanks for the PR. We are holding this one until you can update per @tvillega feedback. We had a hell of a time with observers recently causing havoc so we are keeping a close eye on using them.

@andOrlando

Copy link
Copy Markdown
Author

Yeah, sorry about that--now that it's the weekend I'll hopefully get the chance to fix my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants