fix(secrets-manager): remove bogus sourceSecret property from SecretImporter CRD - #1165
Open
jorgemoralespou wants to merge 1 commit into
Open
Conversation
…mporter CRD The SecretImporter CRD declared a sourceSecret property that the secrets manager never reads; the secret a SecretImporter accepts is always determined from the name of the SecretImporter resource itself. Remove the property from the CRD schema and drop the documentation section that described the non-existent behaviour. Fixes educates#1036
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SecretImportercustom resource definition declared asourceSecretproperty in its schema, and the documentation described it as a way of
qualifying by name which source secret could be copied. The secrets manager
never reads this property: the secret a
SecretImporteraccepts is alwaysdetermined from the name of the
SecretImporterresource itself, and thesource secret name comes from the
SecretCopierorSecretExporterrule.This removes the unused property from the CRD schema, drops the
documentation section that described the non-existent behaviour, and adds a
release notes entry for 4.0.0 noting that manifests which set the field
should remove it, since strict
kubectlfield validation would reject thefield once the schema no longer declares it.
Fixes #1036