Auto-sync FTR Chrome from Kibana ChromeDriver - #7697
Open
gurevichdmitry wants to merge 2 commits into
Open
Conversation
Nightly UI Sanity FTR fails because Kibana's ChromeDriver 151 rejects the pinned Chrome 149 binary. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
This pull request does not have a backport label. Could you fix it @gurevichdmitry? 🙏
|
Avoid hardcoding chrome-version by reading Kibana's devDependencies.chromedriver after checkout so UI Sanity stays in sync when Renovate bumps the driver. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of your changes
Nightly Sanity UI tests fail when Kibana's
chromedrivermajor drifts from the hardcoded Chrome pin in the FTR action (e.g. driver 151 vs Chrome 149).Instead of repeatedly bumping a pin, resolve the Chrome major at runtime from the checked-out Kibana
devDependencies.chromedriver(same source Kibana Renovate updates), then pass it tobrowser-actions/setup-chrome.Failing run that motivated this: https://github.com/elastic/cloudbeat/actions/runs/31291013098/job/93188307309
Also removes the need for follow-up pin PRs like #6253 whenever Kibana bumps chromedriver.
Test plan
Resolved Chrome <major> from Kibana chromedriver@...chromedriver@151.0.3)