fix: prevent orphan empty-timestamp S3 env folders - #7698
Open
gurevichdmitry wants to merge 1 commit into
Open
Conversation
Resolve the S3 state prefix before auth and gate always() env_config uploads so failures cannot create DEPLOYMENT_NAME_/ orphans. Also destroy test-e2e environments when deploy/tests fail so state folders do not pile up. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
This pull request does not have a backport label. Could you fix it @gurevichdmitry? 🙏
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TF_STATE_FOLDER/S3_BUCKET_PATHearly in Create Environment (and EA) so uploads never write toDEPLOYMENT_NAME_/when the timestamp is unset.Upload environment info(if: always()) onS3_BUCKET_PATHbeing set; reuse the resolved path for elk/CDR/CIS uploads.Test plan
Set S3 state folderprecedes vault/auth; no remaining${S3_BASE_BUCKET}/${DEPLOYMENT_NAME}_${TF_STATE_FOLDER}upload paths in create-env workflowsname_YYYY-MM-DD_HH-MM-SSprefix (noname_orphan)Made with Cursor