[Rule: Tuning] Fixing logic issue on the macOS rule for discovery external IP using curl - #6530
Open
litemars wants to merge 5 commits into
Open
[Rule: Tuning] Fixing logic issue on the macOS rule for discovery external IP using curl#6530litemars wants to merge 5 commits into
litemars wants to merge 5 commits into
Conversation
w0rk3r
approved these changes
Jul 30, 2026
w0rk3r
left a comment
w0rk3r
left a comment
Contributor
There was a problem hiding this comment.
Left a suggestion, you also need to bump updated_date. Thanks for the contribution!
shashank-elastic
approved these changes
Jul 30, 2026
shashank-elastic
left a comment
shashank-elastic
left a comment
Contributor
There was a problem hiding this comment.
Approving with Jon's comment, which is a good to have.
Co-authored-by: Jonhnathan <26856693+w0rk3r@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue:
Since curl is always Apple-signed, process.code_signature.exists is always true → the clause is dead and the OR collapses to the parent check.
Summary - What I changed
Checking if the parent process is signed instead of the process itself