Skip to content

Avoid Python shell in composite actions #4089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mpdreamz wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −21
Open

Avoid Python shell in composite actions #4089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions .github/actions/aws-auth/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,20 @@ runs:
steps:
- name: Generate AWS Role ARN
id: role_arn
shell: python
shell: bash
env:
AWS_ACCOUNT_ID: ${{ inputs.aws_account_id }}
ROLE_NAME_PREFIX: ${{ inputs.aws_role_name_prefix }}
run: |
import hashlib
import os
prefix = os.environ["ROLE_NAME_PREFIX"]
m = hashlib.sha256()
m.update(os.environ["GITHUB_REPOSITORY"].encode('utf-8'))
hash = m.hexdigest()[:64-len(prefix)]
with open(os.environ["GITHUB_OUTPUT"], "a") as f:
f.write(f"result=arn:aws:iam::{os.environ["AWS_ACCOUNT_ID"]}:role/{prefix}{hash}")
set -euo pipefail
prefix="${ROLE_NAME_PREFIX}"
if command -v sha256sum >/dev/null 2>&1; then
hash="$(printf '%s' "${GITHUB_REPOSITORY}" | sha256sum | awk '{print $1}')"
else
hash="$(printf '%s' "${GITHUB_REPOSITORY}" | shasum -a 256 | awk '{print $1}')"
fi
hash="${hash:0:$((64 - ${#prefix}))}"
printf 'result=arn:aws:iam::%s:role/%s%s\n' "${AWS_ACCOUNT_ID}" "${prefix}" "${hash}" >> "${GITHUB_OUTPUT}"
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@e6de054238d6b7531b4efff3b6587d9aade6a06c # v6.2.3
with:
Expand Down
22 changes: 10 additions & 12 deletions actions/update-link-index/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,19 @@ runs:
steps:
- name: Generate AWS Role ARN
id: role_arn
shell: python
shell: bash
env:
AWS_ACCOUNT_ID: ${{ inputs.aws_account_id }}
run: |
import hashlib
import os

prefix = "elastic-docs-link-index-uploader-"
aws_account_id = os.environ["AWS_ACCOUNT_ID"]

m = hashlib.sha256()
m.update(os.environ["GITHUB_REPOSITORY"].encode('utf-8'))
hash = m.hexdigest()[:64-len(prefix)]
with open(os.environ["GITHUB_OUTPUT"], "a") as f:
f.write(f"result=arn:aws:iam::{aws_account_id}:role/{prefix}{hash}")
set -euo pipefail
prefix="elastic-docs-link-index-uploader-"
if command -v sha256sum >/dev/null 2>&1; then
hash="$(printf '%s' "${GITHUB_REPOSITORY}" | sha256sum | awk '{print $1}')"
else
hash="$(printf '%s' "${GITHUB_REPOSITORY}" | shasum -a 256 | awk '{print $1}')"
fi
hash="${hash:0:$((64 - ${#prefix}))}"
printf 'result=arn:aws:iam::%s:role/%s%s\n' "${AWS_ACCOUNT_ID}" "${prefix}" "${hash}" >> "${GITHUB_OUTPUT}"
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@e6de054238d6b7531b4efff3b6587d9aade6a06c # v6.2.3
with:
Expand Down
Loading