Conversation
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4120/ Sample changed pages: |
Contributor
There was a problem hiding this comment.
Requesting changes: the current product/version notes flow can surface wrong-product notes in both CDN fallback and amend reconciliation paths.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
lcawl
added this pull request to stack #4123
September 16, 2026 19:49
lcawl
force-pushed
the
changelog-note-registry-fixes
branch
from
September 16, 2026 20:22
1e0bda1 to
80f9d4f
Compare
lcawl
force-pushed
the
changelog-note-registry-fixes
branch
from
September 21, 2026 16:05
80f9d4f to
0457365
Compare
lcawl
force-pushed
the
changelog-note-registry-fixes
branch
from
September 21, 2026 16:06
0457365 to
bf054a0
Compare
Contributor
There was a problem hiding this comment.
No blocking issues found.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
Co-Authored-By: Claude <noreply@anthropic.com>
lcawl
force-pushed
the
changelog-note-registry-fixes
branch
from
September 22, 2026 19:26
cd4534a to
09940a0
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds product-scoped notes indexes that are additive.
To ensure we don't break existing changelog users, the legacy
notes-{version}.jsonkeys stay, and{changelog}still does not read those indexes.Background
Relates to #4090, #4103
Since the related issues touch the same areas of the code and have a significant, overlapping impact, this PR is part of a multi-PR phased approach.
Details
Indexes. The scrubber now writes
changelog/{org}/{repo}/notes-{product}-{version}.json(withproductandversionon the body) and still dual-writesnotes-{version}.jsonas a version union without those fields. Stale product-scoped keys can be deleted; a version-only key is kept while any note still declares that version.Consumers.
changelog bundleGETs the product-scoped URL first and falls back to the version-only URL only on HTTP 404. An empty product-scoped index does not fall back.MergeNotesAsyncwalks each(product, version)from--output-productsand still dedups by checksum.Docs (same change set).
docs/development/changelog-bundle-registry.md,docs/cli/changelog/cmd-note.md, anddocs/cli/changelog/cmd-backfill.md.The dual-write path is in the
changelog-scrubberLambda. It will not show up on the live CDN until that Lambda is deployed.Generative AI disclosure
Tool(s) and model(s) used: Cursor Grok 4.6