Conversation
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4143/ |
reakaleek
added this pull request to stack #4146
September 18, 2026 10:35
Contributor
There was a problem hiding this comment.
Approved: no actionable issues found in this diff.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
reakaleek
force-pushed
the
feat/nav-search-accept-api-hits
branch
from
September 18, 2026 12:23
3cbcdee to
dd6e5ae
Compare
akira28
approved these changes
Sep 21, 2026
Mpdreamz
approved these changes
Sep 22, 2026
The Jump to page hooks rejected type "api" and the store filter used "doc", which never matches indexed "docs". Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com>
reakaleek
force-pushed
the
feat/nav-search-accept-api-hits
branch
from
September 22, 2026 07:38
dd6e5ae to
c4b2a63
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigation-search and Codex modal hooks now parse mixed
docsandapihits. The store type filter matches the indexeddocsvalue.Affects: Site UI, Search
Prompt summary: Ship the Jump to page API story as stacked PRs. This first PR is the root on
mainand covers elastic/docs-eng-team#857: acceptapihits, fix the store type union, and align the mock service.Stack: 1 of 5, root on
main. Later PRs for elastic/docs-eng-team#858 through elastic/docs-eng-team#861 stack on this branch.Why
A navigation-search hit with
type: "api"fails Zod parse and drops the whole response. The store filter still usesdoc, which never matches the indexed valuedocs. Local mock results use the same stale value, so atype=docsquery returns nothing.Closes elastic/docs-eng-team#857
What
Result schema
Both query hooks accept
docsandapion each hit. A mixed response now parses instead of throwing.Type filter
TypeFilteris'all' | 'docs' | 'api'. A latertype=docsquery can match indexed documents.Mock results
MockNavigationSearchServiceemitsType = "docs"so local filtered queries match the same contract.Verify
Out of scope: Mounting the box, the
typeattribute, API-shaped rows, and leftover cleanup. Those land in the stacked PRs above.Made with Cursor