ci: scope faraday trust for electron-node-abi-updater[bot] to abi_registry.json - #298
Merged
Conversation
…istry.json Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011iinJt1jcS3sXqvx8b9grM
MarshallOfSound
approved these changes
Aug 3, 2026
MarshallOfSound
marked this pull request as ready for review
August 3, 2026 05:23
jkleinsc
approved these changes
Aug 3, 2026
|
🎉 This PR is included in version 4.34.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard · Slack thread
Before: Faraday grants electron-node-abi-updater[bot]'s PRs the 1-approval trusted tier — with electron-pr-approver[bot] able to stand in for a human review — for any change in this repo.
After: that trusted tier applies only when the PR touches nothing but
abi_registry.json. Any PR from the bot that modifies anything else falls back to the standard 2-approval requirement (it is never marked red, just held to the normal bar). The paired approver, electron-pr-approver[bot], is automatically confined by the parent entry's scope — approver objects carry nopathskey of their own.How: this uses the
pathskey on trusted-bots entries introduced in electron/faraday#15 (deployed 2026-08-03). Evidence for the chosen scope: all 39 of the bot's PRs in this repo modified exactly this one file. The restriction takes effect once merged to the default branch.Generated by Claude Code