Conversation
|
On reflection this might cause issues with languages that use the singular form for other numbers so returning to draft. |
|
Using |
|
I think that there is still the issue of the whole sentence being made out of concatenation not working for all languages I think |
Remove extraneous parentheses Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
|
@tintou Agreed. I may as well try and fix that here as well. |
|
Keeping everything translatable into all languages is something of a challenge given the variablity of the status messages. I have tried to minimise the different msgids while maintaining flexibility for the translators. Fairly extensive comments are added. I assume that translators are familiar with positional arguments. We may have to more radically change the layout of the status message in English to fully achieve translatability but I have kept fairly close to the existing layout for now. |
Fix indentation Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
Fix whitespace Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
|
@ryonakano Thanks for the review - sorry about the careless mistakes. Hopefully now fixed. |
| str = ngettext ("%u folder selected", "%u folders selected", folders_count).printf ( | ||
| folders_count | ||
| ); |
There was a problem hiding this comment.
| str = ngettext ("%u folder selected", "%u folders selected", folders_count).printf ( | |
| folders_count | |
| ); | |
| str = ngettext ("%u folder selected", "%u folders selected", folders_count).printf ( | |
| folders_count | |
| ); |
The malformed indentation still presents.
Running
io.elementary.files-update-pogives the following warningThis fixes that.