Skip to content

Introduce a BrightnessManager - #2916

Open
leolost2605 wants to merge 8 commits into
mainfrom
leolost/brightness-manager
Open

Introduce a BrightnessManager#2916
leolost2605 wants to merge 8 commits into
mainfrom
leolost/brightness-manager

Conversation

@leolost2605

Copy link
Copy Markdown
Member

Make it build by making sure vala first includes meta/display which contains the necessary macros for the others. I will properly fix this by upstreaming the missing header includes.

@leolost2605
leolost2605 marked this pull request as draft August 30, 2026 15:25
@leolost2605

leolost2605 commented Aug 30, 2026

Copy link
Copy Markdown
Member Author

@garaevdi if you want to take a look :) I fixed the build issues for now by forcing vala to use a certain include order

This follows the gnome shell implementation a bit (mostly regarding to using logical monitors and the global scale calculation which will be used by keybinds to change all monitor brightnesses at the same time while keeping the ratio between the monitors)
Needs still some work and the keybinds are missing but everything else is working already

@danirabbit danirabbit added this to OS 9 Aug 30, 2026
@danirabbit danirabbit moved this to In progress in OS 9 Aug 30, 2026
@garaevdi

Copy link
Copy Markdown
Contributor

@garaevdi if you want to take a look :) I fixed the build issues for now by forcing vala to use a certain include order

Oh, that's smart, didn't know about this trick 😅️

At a glance your implementation looks much cleaner, I'll close my PR. Just a suggestion: how about implicitly placing primary monitor at array's start, so interface consumers could highlight it somehow?

@leolost2605
leolost2605 force-pushed the leolost/brightness-manager branch from 1e6d19f to df2bd3a Compare September 4, 2026 14:57
@leolost2605
leolost2605 marked this pull request as ready for review September 4, 2026 14:57
@leolost2605

Copy link
Copy Markdown
Member Author

At a glance your implementation looks much cleaner, I'll close my PR. Just a suggestion: how about implicitly placing primary monitor at array's start, so interface consumers could highlight it somehow?

Good idea, did that :)

I also added support for the interface the gnome settings daemon expects for auto brightness and dimming on idle and added some docs for the dbus interface. Should be ready for an initial review now

@leolost2605
leolost2605 force-pushed the leolost/brightness-manager branch from 19f4187 to 650081b Compare September 4, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

3 participants