FdoServer: drop bubble reference when destroy() is emitted - #213
Merged
Conversation
Member
|
Thanks for the quick response :) |
Contributor
Author
|
i perfer to revert #211 back to the approved state, the changes done there will make |
Member
|
Oh man I'm starting to loose track 😅. I reverted the changes there |
leolost2605
requested changes
Jul 28, 2023
Member
There was a problem hiding this comment.
Looks good but this line could probably also use a null check
Marukesu
force-pushed
the
maru/drop-bubble
branch
from
July 28, 2023 22:35
8702ac2 to
1a9f64c
Compare
Marukesu
force-pushed
the
maru/drop-bubble
branch
from
July 28, 2023 22:36
1a9f64c to
5ac3060
Compare
Contributor
Author
|
Good catch! Added the null check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
our bubble map was keeping a reference to the bubble, stoping it from being destroyed. drop our reference when
destroy()is emitted.Fixes: #212.