Remove redundant livekit-client pnpm override - #249
Merged
Conversation
@elevenlabs/client depends on livekit-client at an exact 2.16.1, so the override only restated the version the SDK already forces. Dropping it lets the SDK own that version going forward instead of each example needing to track it. Also refreshes the setup-managed dependencies to current latest, as a fresh setup.sh run would. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four examples pinned
livekit-clientto2.16.1underpnpm.overrides. The pin is a no-op:@elevenlabs/client@1.17.0already depends onlivekit-clientat an exact2.16.1, not a range, so the override just restated the version the SDK forces. Removing it lets the SDK own that version instead of every example having to track it.Verified by resolving the tree with the override gone — all four examples still install
livekit-client 2.16.1:The original reason for the pin is also gone server-side.
livekit.rtc.elevenlabs.io/rtc/v1/validate, the path whose 404s motivated the pin, now answers400 join_request is required. That is moot while the SDK hard-pins2.16.1, but it means there is no longer a known-broken version to defend against.Removed from
setup.shandexample/package.jsonin:agents/nextjs/quickstartagents/nextjs/guardrailsagents/expo/quickstartspeech-engine/nextjs/quickstartAlso dropped the instruction to add the pin from
speech-engine/nextjs/quickstart/PROMPT.mdand the mention in the scaffold skill'sreference.md, so a regeneration run does not reintroduce it.Dependencies were re-resolved from scratch (lockfiles deleted) and the setup-managed versions bumped to current latest, matching what a fresh
setup.shproduces:@elevenlabs/react1.12.0,@elevenlabs/elevenlabs-js2.60.0, plusopenai7.3.0 andtsx4.23.5 for speech-engine.Test plan
Verified locally:
next buildpasses for all three Next.js examplestsc --noEmitpasses for the Expo examplenpx prettier . --checkandruff check .both passlivekit-clientstill resolves to2.16.1in all four examples/api/conversation-tokenreturns a real token in both agents examples, and those tokens validate200 successagainstlivekit.rtc.elevenlabs.io/rtc/validate/api/chatworks on theopenai6 → 7 major bumpNot covered:
server.mts— theELEVENLABS_SPEECH_ENGINE_IDin my local.envreturns 404 from the API, so that resource needs recreating before it can be exercisedMade with Cursor