Support configuration file and sharing as read only - #14
Conversation
Per default configuration file will be ignored or will be loaded from $HOME/.tty-share if this file exists. A non-default config file behaviour can be changed using -config flag to specify a config file name.
|
Sharing |
| // CLI options override any config file settings, having config file is useful | ||
| // for changing default options | ||
| func (conf *TTYShareConfig) Load() { | ||
| defConfigFileName := os.Getenv("HOME") + "/." + path.Base(os.Args[0]) |
There was a problem hiding this comment.
Please consider following the XDG Base Directory Specification on where to save configuration files!
https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
|
This work would be easier for (@elisescu?) to review if it was introduced in two separate PRs, one for adding config file support and one for adding read-only support. I also feel like read-only support should have some corresponding implementation over in https://github.com/elisescu/tty-server so it's clear to the user in the browser that they can't input ... ! |
|
I second the request for config files - In place of that, for now we've the option of aliasing |
5 participants
No description provided.