add support for timeouts - #88
Open
cfal wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks @cfal, nice little feature. I do have one inline comment. Let me know if you are interested to change that, otherwise I can do it. |
Contributor
Author
elisescu
reviewed
Sep 4, 2025
| tunnelConfig := flag.String("L", "", "[c] TCP tunneling addresses: local_port:remote_host:remote_port. The client will listen on local_port for TCP connections, and will forward those to the from the server side to remote_host:remote_port") | ||
| crossOrgin := flag.Bool("cross-origin", false, "[s] Allow cross origin requests to the server") | ||
| baseUrlPath := flag.String("base-url-path", "", "[s] The base URL path on the serve") | ||
| timeoutDuration := flag.Duration("timeout", 0, "[s] The max duration the tty-server session should run for, before timing out. The value is a sequence of numbers with time units, eg. 10m, 1h, 1h30m10s") |
Owner
There was a problem hiding this comment.
I think the "timeout" flag name can be confused with a timeout of the connection in case of network issues, so I would rather find a different name for the "feature" and the flag. Something that communicates more clearly that this is not a connection timeout, but a maximum for the lifetime of the connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi @elisescu , this PR adds support for timeouts for privacy - i'm worried that i left an active tty-share session around, and so usually schedule a
pkill tty-share, but that doesn't work well without more complex code for the scenario that i have multiple tty-share sessions started. please take a look, thanks!