Various perf improvements - #258
Open
jfmengels wants to merge 123 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through the repo and found a bunch of (micro-)optimizations and some cleanup changes. (No AI involved)
I tried to make it so no commit should ever make any behavioral change. If you find some, then that is a mistake on my part that should be fixed. Some commits make the code worse but are improved in the following commits, usually in an attempt to explain through tiny steps that code is equivalent. In some cases, the code ends up maybe harder to read but should be faster.
Feel free to ask me to make changes, and/or to pick or discard whatever you (don't) like.