Move plan picker back out of the title, into its own secondary chip - #19
Merged
Conversation
Reverts the "tap the title" version from the previous PR based on
feedback: the title-embedded picker scaled fine but took over the
static "Plan" title, which read as less clear than the original
segmented control's distinct, separate-control feel — even though
that control itself didn't scale past a couple of plans.
PlanPicker is now a single chip button ("{plan name} ▾") in its own
full-width bar above the day list, in the segmented control's old
position, opening the same checkmarked dropdown menu on tap. The
title goes back to always being plain generic text ("Plan"), and
Layout's header grid no longer needs to reserve space for a
title-embedded control now that there isn't one — the reverted grid
change also fixes itself, since the chip has a full row to itself and
no longer competes with the Completed checkbox for width, giving it
more room for long plan names than either earlier design had.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K2wCTwwVhhkSDxQxWo7UoH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the "tap the title" plan picker from the previous PR based on feedback: it scaled fine to any number of plans, but taking over the static "Plan" title read as less clear than the original segmented control's distinct, separate-control feel — even though that control itself didn't scale past a couple of plans.
PlanPickeris now a single chip button ("{plan name} ▾") in its own full-width bar above the day list — the segmented control's old position — opening the same checkmarked dropdown menu on tap. The title goes back to always being plain generic text ("Plan"), andLayout's header grid no longer needs the space-reservation logic from the last PR now that there's nothing sharing the title's row. As a side benefit, the chip has a full row to itself with no Completed checkbox competing for width, so it has noticeably more room for long plan names than either earlier design did.Test plan
npm run buildpassestsc --noEmitpassestext-overflow: ellipsis, with visibly more room than the previous title-embedded version hadGenerated by Claude Code