Remove windows .bat and .ps1 launchers - #27359
Open
sbc100 wants to merge 1 commit into
Open
Conversation
sbc100
marked this pull request as draft
July 15, 2026 15:41
sbc100
force-pushed
the
remove_bat_files
branch
from
September 1, 2026 21:31
4929920 to
ac8d7b2
Compare
We have been using the .exe launchers for a few releases not with no issue. See emscripten-core#24858
sbc100
force-pushed
the
remove_bat_files
branch
from
September 3, 2026 19:20
ac8d7b2 to
a1febca
Compare
sbc100
marked this pull request as ready for review
September 3, 2026 23:40
Collaborator
Author
|
@juj, I will wait for you to confirm that the new binary launcher is working for you before I land this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been using the .exe launchers for a few releases now, with no outstanding issues
We should probably wait a little longer for it to bake but eventually I would like to land this change.
See #24858