fix(issue-discovery): skip unscored OSS PRs in solving-PR cache - #1678
Open
bittensorrider wants to merge 1 commit into
Open
fix(issue-discovery): skip unscored OSS PRs in solving-PR cache#1678bittensorrider wants to merge 1 commit into
bittensorrider wants to merge 1 commit into
Conversation
Incomplete score_pr early-returns left token_score=0 defaults in merged_prs, which poisoned the discovery cache and blocked file refetch for valid solves. Mark completed OSS scoring via oss_scored and only cache those entries. Fixes entrius#1677 Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Hi @anderdc @LandynDev — first contribution from me on this repo. GitHub Actions for this PR are waiting on maintainer approval for first-time contributor workflows (Lint + Tests). Could you please approve the workflows when you have a moment, and review if possible? Fixes #1677. Local pre-commit + pre-push (ruff/pyright/vulture/pytest) already pass on my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScoredPR.oss_scored, set only whenscore_prfinishes multipliers (not on early-return)._build_solving_pr_cachecaches onlyoss_scoredPRs so incomplete OSS defaults (token_score=0) no longer suppressget_pr_filesduring issue discovery.Related Issues
Fixes #1677
Type of Change
Testing
uv run pre-commit run --all-filesuv run pre-commit run --all-files --hook-stage pre-push(pyright, vulture, full pytest)Checklist