feat: export images from private event activities - #210
Open
MakikoOhashi wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @eoleedi,
First of all, thank you very much for this project! It has been incredibly helpful.
I wanted to move our family's long-running TimeTree calendar into Notion, and TimeTree Exporter made it possible to preserve years of our calendar history.
While doing that, I noticed that images attached to private events were not included in the export. In our case, many of those images only make sense together with the event they belong to, so I experimented with preserving them as well.
This PR adds an optional
--include-imagesfeature for private calendars.What it does
--include-commentsand--include-imagesare used togethertimetree_images/{event_uuid}/...timetree_images.jsonto preserve the relationship between events and imagesI kept this opt-in because it requires additional requests and can take quite a while for large calendars. I also chose not to embed the images into the ICS itself; the JSON manifest is only a sidecar for preserving the event-to-image relationship.
Testing
I tested this with my own private calendar:
Automated checks:
ruff checkpassedruff format --checkpassedgit diff --checkpassedI'm not sure whether this kind of sidecar image export fits the intended scope of TimeTree Exporter, since it goes a little beyond ICS output itself. If you would prefer to keep the project focused strictly on ICS export, please feel completely free to close this PR. I would absolutely understand.
Either way, thank you again for making this project available. It helped me a lot with preserving our family's TimeTree history.