Fix/filter/max depth observable - #3333
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 0318e17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an infinite render loop introduced after upgrading @equinor/fusion-observable by ensuring FilterOptionHeader uses a stable selector function when deriving the selected-option count from an observable selection set.
Changes:
- Extracted the selection-size selector into a module-level function to keep selector identity stable across renders.
- Updated
FilterOptionHeaderto use the stabilized selector when callinguseObservableSelector. - Added a patch changeset for
@equinor/fusion-react-filterdescribing the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/filter/src/components/filter/FilterOptionHeader.tsx | Stabilizes the selector function passed to useObservableSelector to avoid re-creating derived observables each render. |
| .changeset/stable-filter-selector.md | Adds a patch changeset documenting the render-loop fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
odinr
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After upgrading
@equinor/fusion-observable,FilterOptionHeaderentered an infinite render loop because its inline selector created a new derived observable on every render.What changed
useObservableStatefrom repeatedly resubscribing@equinor/fusion-react-filterValidation
bun run --cwd packages/filter buildReference
Related to https://github.com/equinor/fusion/issues/889