Add support for DurationInTraffic - #157
Open
PeterDavidson wants to merge 5 commits into
Open
Conversation
Add duration_in_traffic to DirectionLeg
… requested, and also updated to the latest Newtonsoft.Json
Author
|
Note that this closes #128 |
…t Standard 2.0 (since it was causing build errors).
|
Any plans to accept this PR? |
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>net461;netstandard1.3</TargetFrameworks> | ||
| <TargetFrameworks>netstandard2.0</TargetFrameworks> |
Owner
There was a problem hiding this comment.
unfortunately this change makes it much harder to approve the pull request. I would consider changing the targetframework to be considered out of scope of adding traffic_model to the request.
ericnewton76
added
awaiting reply
out-of-scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the DepartureTime is set then Google can return congested travel times. This adds support for obtaining the new output, as well as an extra setting in the request to specify the traffic model to use.
I also updated the Newtonsoft.Json to the latest version.